[Multi-year Part II] Add low sum limit for transport vintage outgoing flows for semi-compact method (#1326)

* Add con indices

* Update con indices and create con

* Update constraints and add tests

* Remove the other lower bound to leave on this new one for semi-compact

* Refactor the tranport constraints

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Update src/sql/create-constraints.sql

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

* Apply review suggestions to other applicable places

---------

Co-authored-by: Abel Soares Siqueira <nepper271@gmail.com>

Author: gnawin

src/constraints/create.jl

@@ -29,6 +29,7 @@ function compute_constraints_indices(connection)
             :max_energy_over_clustered_year,
             :transport_flow_limit_simple_method,
             :min_outgoing_flow_for_transport_flows_without_unit_commitment,
+            :min_outgoing_flow_for_transport_vintage_flows,
             :min_incoming_flow_for_transport_flows,
             :group_max_investment_limit,
             :group_min_investment_limit,

src/constraints/transport.jl

@@ -12,6 +12,44 @@ function add_transport_constraints!(
     expressions,
     constraints,
     profiles,
+)
+    # - Capacity limits for transport flows including lower bounds and upper bounds
+    add_capacity_limits_transport_flows!(
+        connection,
+        model,
+        variables,
+        expressions,
+        constraints,
+        profiles,
+    )
+
+    # - Minimum output flows limit if any of the flows is transport flow
+    # - This allows some negative flows but not all negative flows, so transport flows can pass
+    # - through this asset
+    # - Holds for producers, conversion and storage assets
+    add_min_outgoing_flow_for_transport_flows_without_unit_commitment(model, constraints)
+
+    # - Minimum output vintage flows limit if any of the flows is transport flow
+    # - Since regular flow is a special case of the vintage_flow, vintage_flow has to have the same
+    # - constraint as the regular flow above
+    add_min_outgoing_flow_for_transport_vintage_flows(model, constraints)
+
+    # - Minimum input flows limit if any of the flows is transport flow
+    # - This allows some negative flows but not all negative flows, so transport flows can pass
+    # - through this asset
+    # - Holds for conversion and storage assets
+    add_min_incoming_flow_for_transport_flows(model, constraints)
+
+    return
+end
+
+function add_capacity_limits_transport_flows!(
+    connection,
+    model,
+    variables,
+    expressions,
+    constraints,
+    profiles,
 )
     ## unpack from model
     expr_avail = expressions[:available_flow_units_simple_method]
@@ -89,10 +127,9 @@ function add_transport_constraints!(
             ],
         )
     end
+end
 
-    # - Minimum output flows limit if any of the flows is transport flow
-    # - This allows some negative flows but not all negative flows, so transport flows can pass through this asset
-    # - Holds for producers, conversion and storage assets
+function add_min_outgoing_flow_for_transport_flows_without_unit_commitment(model, constraints)
     let table_name = :min_outgoing_flow_for_transport_flows_without_unit_commitment,
         cons_name = Symbol("min_output_flows_limit_for_transport_flows_without_unit_commitment")
 
@@ -110,10 +147,29 @@ function add_transport_constraints!(
             ],
         )
     end
+end
 
-    # - Minimum input flows limit if any of the flows is transport flow
-    # - This allows some negative flows but not all negative flows, so transport flows can pass through this asset
-    # - Holds for conversion and storage assets
+function add_min_outgoing_flow_for_transport_vintage_flows(model, constraints)
+    let table_name = :min_outgoing_flow_for_transport_vintage_flows,
+        cons_name = Symbol("min_output_flows_limit_for_transport_vintage_flows")
+
+        attach_constraint!(
+            model,
+            constraints[table_name],
+            cons_name,
+            [
+                @constraint(
+                    model,
+                    outgoing_flow ≥ 0,
+                    base_name = "$cons_name[$(row.asset),$(row.milestone_year),$(row.commission_year),$(row.rep_period),$(row.time_block_start):$(row.time_block_end)]"
+                ) for (row, outgoing_flow) in
+                zip(constraints[table_name].indices, constraints[table_name].expressions[:outgoing])
+            ],
+        )
+    end
+end
+
+function add_min_incoming_flow_for_transport_flows(model, constraints)
     let table_name = :min_incoming_flow_for_transport_flows,
         cons_name = Symbol("min_input_flows_limit_for_transport_flows")
 
@@ -131,8 +187,6 @@ function add_transport_constraints!(
             ],
         )
     end
-
-    return
 end
 
 function _append_transport_data_to_indices(connection)

src/model-preparation.jl

@@ -519,16 +519,19 @@ function add_expressions_to_constraints!(connection, variables, constraints)
         multiply_by_duration = false,
     )
 
-    @timeit to "add_expression_terms_rep_period_constraints!" add_expression_terms_rep_period_constraints!(
-        connection,
-        constraints[:capacity_outgoing_semi_compact_method],
-        variables[:vintage_flow],
-        workspace;
-        use_highest_resolution = true,
-        multiply_by_duration = false,
-        multiply_by_capacity_coefficient = true,
-        include_commission_year = true,
-    )
+    for table_name in
+        (:capacity_outgoing_semi_compact_method, :min_outgoing_flow_for_transport_vintage_flows)
+        @timeit to "add_expression_terms_rep_period_constraints! for $table_name" add_expression_terms_rep_period_constraints!(
+            connection,
+            constraints[table_name],
+            variables[:vintage_flow],
+            workspace;
+            use_highest_resolution = true,
+            multiply_by_duration = false,
+            multiply_by_capacity_coefficient = true,
+            include_commission_year = true,
+        )
+    end
 
     for table_name in (
         :capacity_incoming_simple_method,

src/sql/create-constraints.sql

@@ -272,22 +272,24 @@ drop table if exists cons_min_outgoing_flow_for_transport_flows_without_unit_com
 
 create table cons_min_outgoing_flow_for_transport_flows_without_unit_commitment as
 -- We want to check if the outgoing flows of an asset have transport flows
+-- Note we assume that the this property does not change across the years
+-- In other words, we assume the underlying graph does not change
 -- This information is gathered from the flow table
 -- COALESCE is used to handle the case where there are no outgoing flows
 with
-    transport_flow_info as (
+    cte_transport_flow_info as (
         select
             asset.asset,
             coalesce(
                 (
                     select
-                        bool_or(flow.is_transport)
+                        bool_or(flow.is_transport) -- true if any outgoing flow is transport
                     from
                         flow
                     where
                         flow.from_asset = asset.asset
                 ),
-                false
+                false -- coalescing to false in case there are no outgoing flows
             ) as outgoing_flows_have_transport_flows,
         from
             asset
@@ -298,12 +300,67 @@ select
 from
     t_highest_out_flows as t_high
     left join asset on t_high.asset = asset.asset
-    left join transport_flow_info on t_high.asset = transport_flow_info.asset
+    left join cte_transport_flow_info on t_high.asset = cte_transport_flow_info.asset
 where
     asset.type in ('producer', 'storage', 'conversion')
-    and transport_flow_info.outgoing_flows_have_transport_flows
+    and cte_transport_flow_info.outgoing_flows_have_transport_flows
     -- Assets with unit commitment already have a minimum outgoing flow constraints
     and not asset.unit_commitment
+    and asset.investment_method in ('compact', 'simple', 'none')
+;
+
+drop sequence id
+;
+
+create sequence id start 1
+;
+
+drop table if exists cons_min_outgoing_flow_for_transport_vintage_flows
+;
+
+-- This constraint is very similar to cons_min_outgoing_flow_for_transport_flows_without_unit_commitment
+-- but it applies to vintage flows instead of regular flows
+create table cons_min_outgoing_flow_for_transport_vintage_flows as
+with
+    cte_transport_flow_info as (
+        select
+            asset.asset,
+            coalesce(
+                (
+                    select
+                        bool_or(flow.is_transport) -- true if any outgoing flow is transport
+                    from
+                        flow
+                    where
+                        flow.from_asset = asset.asset
+                ),
+                false -- coalescing to false in case there are no outgoing flows
+            ) as outgoing_flows_have_transport_flows,
+        from
+            asset
+    )
+select
+    nextval('id') as id,
+    t_high.asset as asset,
+    t_high.year as milestone_year,
+    asset_both.commission_year as commission_year,
+    t_high.rep_period,
+    t_high.time_block_start,
+    t_high.time_block_end
+from
+    t_highest_out_flows as t_high
+    left join asset on t_high.asset = asset.asset
+    left join cte_transport_flow_info on t_high.asset = cte_transport_flow_info.asset
+    left join asset_both on t_high.asset = asset_both.asset
+        and t_high.year = asset_both.milestone_year
+where
+    asset.type in ('producer', 'storage', 'conversion')
+    and asset.investment_method = 'semi-compact'
+    and cte_transport_flow_info.outgoing_flows_have_transport_flows
+    -- Note we do not exclude UC here, because UC only guarantees
+    -- the minimum point of flow, instead of vintage flow
+    -- For the same reason, we cannot reuse cons_min_outgoing_flow_for_transport_flows_without_unit_commitment
+    -- directly
 ;
 
 drop sequence id
@@ -319,20 +376,20 @@ create table cons_min_incoming_flow_for_transport_flows as
 -- Similar to the previous query, but for incoming flows
 -- Also for assets with unit commitment
 with
-    transport_flow_info as (
+    cte_transport_flow_info as (
         select
             asset.asset,
             coalesce(
                 (
                     select
-                        bool_or(flow.is_transport)
+                        bool_or(flow.is_transport) -- true if any incoming flow is transport
                     from
                         flow
                     where
                         flow.to_asset = asset.asset
                 ),
-                false
-            ) as incoming_flows_have_transport_flows,
+                false -- coalescing to false in case there are no incoming flows
+            ) as incoming_flows_have_transport_flows
         from
             asset
     )
@@ -342,10 +399,11 @@ select
 from
     t_highest_out_flows as t_high
     left join asset on t_high.asset = asset.asset
-    left join transport_flow_info on t_high.asset = transport_flow_info.asset
+    left join cte_transport_flow_info on t_high.asset = cte_transport_flow_info.asset
 where
     asset.type in ('storage', 'conversion')
-    and transport_flow_info.incoming_flows_have_transport_flows
+    and cte_transport_flow_info.incoming_flows_have_transport_flows
+    and asset.investment_method in ('compact', 'simple', 'none')
 ;
 
 drop sequence id

test/inputs/Multi-year Investments/flow-commission.csv

@@ -3,7 +3,6 @@ battery,demand,2030,0.0,350.0,,1,1.0
 wind,demand,2020,0.0,350.0,,1,1.0
 wind,demand,2030,0.0,350.0,,1,1.0
 ens,demand,2050,0.0,350.0,,1,1.0
-ccgt,demand,2028,1.0,350.0,,1,1.0
 ccgt,demand,2030,2.0,350.0,100.0,1,1.0
 ocgt,demand,2030,0.0,350.0,,1,1.0
 solar,demand,2050,0.0,350.0,,1,1.0