Fix Overflow and Range errors #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code works in 10.3.3 Unknown in 10.4.2 TRandom.Next overflows 64 bits in 11 & 12 And Range error in NextBytes with UInt32 returned to an Integer variable (Rnd)
|
This looks good, but can you provide a test case that fails on the old code and passes with the new code? If that isn't too much trouble it would be helpful. |
Tests submitted as a separate PR. ✅ |
|
merged. sorry for the delay, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution due to Kas Ob at Delphi-Praxis : https://en.delphipraxis.net/topic/13377-overflow-checking-from-104-onwards
Current code works in 10.3.3, Unknown in 10.4.2
TRandom.Next overflows 64 bits in 11 & 12
and Range Error in NextBytes with UInt32 returned to an Integer variable (Rnd)