Vectors #2074
Vectors #2074
Conversation
timeutills V1
github-actions
bot
added
the
pr: new extension
|
there is no block for deleting vectors? |
|
also please run !format |
|
!format |
Yes, just stop using a vector |
|
!format |
|
@fath11 there is now |
| opcode: "vectorCreate", | ||
| blockType: Scratch.BlockType.COMMAND, | ||
| text: Scratch.translate( | ||
| "create vector with ID [ID], direction [DIRECTION] and magnitude [MAGNITUDE]" |
There was a problem hiding this comment.
you have inconsistent capitalization across the blocks, the blocks should be written starting with lowercase. they are NOT sentences.
extensions/unknown/vectors.js
Outdated
| } | ||
|
|
||
| vectorCreate(args) { | ||
| const id = args.ID; |
There was a problem hiding this comment.
you don't cast anything, this is poor practice
There was a problem hiding this comment.
aren't they numbers, you can not put strings in there, and if you could, who would?
There was a problem hiding this comment.
I see now, attempted to fix, fucked up the code
There was a problem hiding this comment.
fixed the fuck up, now works better
| } | ||
|
|
||
| // Vectors storage | ||
| const ids = []; |
|
|
||
| // Vectors storage | ||
| const ids = []; | ||
| const directions = {}; |
There was a problem hiding this comment.
these should be Object.create(null); or a Map
extensions/unknown/vectors.js
Outdated
|
|
||
| vectorMag(args) { | ||
| const id = args.ID; | ||
| return magnitudes[id] ?? Scratch.translate("vector not found"); |
There was a problem hiding this comment.
you should return an empty string or 0 here
There was a problem hiding this comment.
do I want people to wonder why their shit isn't working? if you said yes then you are wrong, the answer is no.
There was a problem hiding this comment.
do I want people to wonder why their shit isn't working? if you said yes then you are wrong, the answer is no.
@GarboMuffin said to chill the language
There was a problem hiding this comment.
decided upon making it "null"
extensions/unknown/vectors.js
Outdated
|
|
||
| vectorDir(args) { | ||
| const id = args.ID; | ||
| return directions[id] ?? Scratch.translate("vector not found"); |
|
Maps are < >, it does what it needs to do very well |
|
!format |
|
it would be wonderful if you would be more reasonable with your language on this issue tracker |
|
it already does what it needs to do, I don't want to spend multiple hours rewriting the entire extension |
|
!format |
| const id = Scratch.Cast.toString(args.ID); | ||
| return magnitudes[id] !== undefined | ||
| ? magnitudes[id] | ||
| : Scratch.translate("null"); |
There was a problem hiding this comment.
translating block return values is usually not a good idea; people may compare the result of this block to the string null (or whatever it is in their language) and then have it break in other languages that have a different string for it.
(null specifically is a fairly language-neutral word so it should be fine untranslated. or you could follow Scratch's precedent and return an empty string; this is what lists also do for example so I don't think it would be confusing)
Vectors is a extension for Vectors
Blocks: Create vector with ID,direction and magnitude: creates a vector, vector direction, returns direction of the vector based on ID, vector magnitude, returns magnitude of the vector based on ID, Change Magnitude and direction, changes magnitude and direction of the vector based on ID, and List of IDs, lists all elements in IDs