Skip to content

Commit 699a61c

Browse files
Use public LinearAlgebra.cholesky interface
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
1 parent 1fcca65 commit 699a61c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/utils.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ rather than `LowerTriangular`.
4343
that returns a `Matrix` rather than `LowerTriangular`.
4444
"""
4545
cholesky_lower(X::AbstractMatrix) = lower_triangular(parent(cholesky(Hermitian(X, :L)).L))
46-
cholesky_lower(X::PDMat) = X.chol.L
46+
cholesky_lower(X::PDMat) = cholesky_lower(cholesky(X))
4747
cholesky_lower(X::Cholesky) = X.L
4848

4949
"""
@@ -57,7 +57,7 @@ rather than `UpperTriangular`.
5757
that returns a `Matrix` rather than `UpperTriangular`.
5858
"""
5959
cholesky_upper(X::AbstractMatrix) = upper_triangular(parent(cholesky(Hermitian(X)).U))
60-
cholesky_upper(X::PDMat) = X.chol.U
60+
cholesky_upper(X::PDMat) = cholesky_upper(cholesky(X))
6161
cholesky_upper(X::Cholesky) = X.U
6262

6363
"""

0 commit comments

Comments
 (0)