Fix stack overflow in make_chain_from_prior

[penelopeysm]

As title. see #1019 (comment)

[github-actions]

Benchmark Report for Commit 5002dbe

Computer Information

Julia Version 1.11.6
Commit 9615af0f269 (2025-07-09 12:58 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  8.9 |                 1.5 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                643.1 |                44.8 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                422.8 |                56.3 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1147.2 |                30.9 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               6561.7 |                30.3 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1437.5 |                28.9 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |               1003.3 |                 4.5 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5791.0 |                 4.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |                988.7 |                 9.1 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              65431.5 |                 3.7 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8974.5 |                 9.7 |
|               Dynamic |        10 |    mooncake |             typed |   true |                132.2 |                12.1 |
|              Submodel |         1 |    mooncake |             typed |   true |                 12.6 |                 4.9 |
|                   LDA |        12 | reversediff |             typed |   true |               1093.1 |                 2.3 |

[coveralls]

Pull Request Test Coverage Report for Build 16861731504

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-1.5%) to 81.023%

---

Totals
Change from base Build 16835552876:	-1.5%
Covered Lines:	3185
Relevant Lines:	3931

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 16861731504

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 82.558%

---

Totals
Change from base Build 16835552876:	0.0%
Covered Lines:	3247
Relevant Lines:	3933

---

💛 - Coveralls

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.07%. Comparing base (b1241b1) to head (5002dbe).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b1241b1) and HEAD (5002dbe). Click for more details.

HEAD has 22 uploads less than BASE

Flag	BASE (b1241b1)	HEAD (5002dbe)
	24	2

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1020       +/-   ##
===========================================
- Coverage   82.30%   34.07%   -48.24%     
===========================================
  Files          38       38               
  Lines        3945     3921       -24     
===========================================
- Hits         3247     1336     -1911     
- Misses        698     2585     +1887     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.