Skip to content

Conversation

penelopeysm
Copy link
Member

default_accumulators() no longer needs an integer type because it was only used for num_produce which is now gone.

This is too trivial a change so I won't bother making a release

Copy link
Contributor

github-actions bot commented Aug 29, 2025

Benchmark Report for Commit 3264f36

Computer Information

Julia Version 1.11.6
Commit 9615af0f269 (2025-07-09 12:58 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.5 |                 1.4 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                655.2 |                43.5 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                428.4 |                60.1 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1117.7 |                32.1 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               6857.2 |                25.7 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1433.9 |                29.5 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |               1010.1 |                 4.6 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5844.7 |                 4.3 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |                993.1 |                 9.0 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              65558.7 |                 3.9 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8511.3 |                10.1 |
|               Dynamic |        10 |    mooncake |             typed |   true |                129.7 |                12.3 |
|              Submodel |         1 |    mooncake |             typed |   true |                 12.8 |                 5.3 |
|                   LDA |        12 | reversediff |             typed |   true |               1140.6 |                 2.7 |

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.26%. Comparing base (0cf3440) to head (3264f36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1025   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files          38       38           
  Lines        3947     3947           
=======================================
  Hits         3247     3247           
  Misses        700      700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17326984245

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 82.414%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 86.73%
src/simple_varinfo.jl 2 70.86%
src/varinfo.jl 6 84.65%
src/threadsafe.jl 10 64.86%
Totals Coverage Status
Change from base Build 16942570157: -0.1%
Covered Lines: 3243
Relevant Lines: 3935

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17326984245

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage remained the same at 82.516%

Files with Coverage Reduction New Missed Lines %
src/model.jl 1 86.73%
src/simple_varinfo.jl 2 70.86%
src/varinfo.jl 6 84.65%
src/threadsafe.jl 10 64.86%
Totals Coverage Status
Change from base Build 16942570157: 0.0%
Covered Lines: 3247
Relevant Lines: 3935

💛 - Coveralls

@penelopeysm penelopeysm enabled auto-merge August 29, 2025 16:12
@penelopeysm penelopeysm disabled auto-merge August 29, 2025 22:08
@penelopeysm penelopeysm merged commit 5742078 into main Aug 29, 2025
21 of 23 checks passed
@penelopeysm penelopeysm deleted the py/no-int-type branch August 29, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants