-
Notifications
You must be signed in to change notification settings - Fork 36
InitContext
, part 2 - Move hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict
#980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
penelopeysm
wants to merge
5
commits into
breaking
Choose a base branch
from
py/hasgetvalue
base: breaking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Report for Commit 21cf568Computer Information
Benchmark Results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## breaking #980 +/- ##
============================================
- Coverage 82.67% 81.92% -0.75%
============================================
Files 38 37 -1
Lines 4022 3994 -28
============================================
- Hits 3325 3272 -53
- Misses 697 722 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DynamicPPL.jl documentation for PR #980 is available at: |
This was referenced Jul 9, 2025
90e95e1
to
21cf568
Compare
hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict{VarName}
instancesInitContext
II - Move hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict{VarName}
instances
InitContext
II - Move hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict{VarName}
instancesInitContext
, part 2 - Move hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict{VarName}
instances
InitContext
, part 2 - Move hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict{VarName}
instancesInitContext
, part 2 - Move hasvalue
and getvalue
to AbstractPPL; enforce key type of AbstractDict
This was referenced Jul 10, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: Adding
hasvalue
andgetvalue
to AbstractPPLThis is Part 2/N of splitting #967 up into manageable bits.
In Part 1 we defined the following methods in AbstractPPL:
This PR removes them (and their helper functions) from the DynamicPPL codebase.
In DynamicPPL, their type bounds for Dict arguments were too lax: they used to take
AbstractDict{<:Any}
as the first argument. The AbstractPPL versions have tighter bounds. This PR therefore switches all overly-loosely-typed Dicts to use a key type of VarName.Closes #791