InitContext, part 3 - Introduce InitContext
#981
Draft
+456
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Report for Commit b55c1e1Computer InformationBenchmark Results |
|
DynamicPPL.jl documentation for PR #981 is available at: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## py/hasgetvalue #981 +/- ##
==================================================
+ Coverage 81.92% 82.18% +0.26%
==================================================
Files 37 38 +1
Lines 3994 4048 +54
==================================================
+ Hits 3272 3327 +55
+ Misses 722 721 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
penelopeysm
commented
Jul 10, 2025
Comment on lines
-283
to
-287
| """ | ||
| prefix(model::Model, x::VarName) | ||
| prefix(model::Model, x::Val{sym}) | ||
| prefix(model::Model, x::Any) | ||
|
|
There was a problem hiding this comment.
This code was shifted verbatim to src/model.jl to avoid circular dependencies between files.
This was referenced Jul 10, 2025
penelopeysm
force-pushed
the
py/hasgetvalue
branch
from
90e95e1 to
21cf568
Compare
penelopeysm
changed the title
InitContextInitContext, part 3 - Introduce InitContext
penelopeysm
force-pushed
the
py/init-prior-uniform
branch
from
f1d5f20 to
025aa8b
Compare
Note that, apart from being simpler code, Distributions.Uniform also doesn't allow the lower and upper bounds to be exactly equal (but we might like to keep that option open in DynamicPPL, e.g. if the user wants to initialise all values to the same value in linked space).
penelopeysm
force-pushed
the
py/init-prior-uniform
branch
from
025aa8b to
b55c1e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: Adding
hasvalueandgetvalueto AbstractPPLPart 2: Removing
hasvalueandgetvaluefrom DynamicPPLThis is Part 3/N of splitting up #967.
This PR solely adds the code for a new leaf context,
InitContext. Its behaviour is to always override existing values inside a VarInfo.A long-held goal of mine is to split up
contexts.jlandcontext_implementations.jlsuch that each context is in its own file. To help get us to this stage, I've put all theInitContext-related code insidesrc/contexts/init.jl. This should, hopefully, also make reviewing easier.InitContextcomes in three forms:PriorInit: Samples values from the prior;UniformInit(min, max): Samples values from betweenminandmaxbefore invlinking them back into the support of the original distribution;ParamsInit(params): Takes values fromparams, which can be a NamedTuple or a Dict. Also takes a fallback strategy, which is used in case the varname is not found inparams.PriorInitandUniformInithave almost one-to-one correspondence withSampleFromPriorandSampleFromUniform. I haven't removed them yet because a LOT of stuff depends onSampleFromPrior. We will eventually remove all of it but doing it in a single PR would make it way too big.However,
ParamsInitis new. Its purpose is to set fixed values in a VarInfo in a principled manner. Right now, there is a fair amount of code that does low-level VarInfo manipulation by reaching inside and modifying the underlying arrays, such asinitialise_values!!, andsetval_and_resample!. This is prone to bugs, and also leads to (for example) the VarInfo's logp being out of sync. (All of that code will be removed in subsequent PRs.)ParamsInitaccomplishes the same in a much cleaner way, although in some cases it may necessitate one extra model evaluation. Because initialisation is not meant to happen within a tight loop (by definition it happens once), I don't consider performance to be an important issue.Closes #375.