InitContext, part 5 - Remove SamplingContext, SampleFrom{Prior,Uniform}, {tilde_,}assume
#985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/remove-samplingcontext
branch
2 times, most recently
from
c32d112 to
b7221cc
Compare
penelopeysm
changed the title
InitContext, part 5 - Remove SamplingContext, SampleFromPrior, SampleFromUniform, and associated codeInitContext, part 5 - Remove SamplingContext, SampleFrom{Prior,Uniform}, {tilde_,}assume
This was referenced Jul 10, 2025
Draft
penelopeysm
force-pushed
the
py/remove-samplingcontext
branch
from
b7221cc to
3835d01
Compare
penelopeysm
force-pushed
the
py/actually-use-init
branch
from
d55d378 to
a392451
Compare
penelopeysm
force-pushed
the
py/remove-samplingcontext
branch
from
3835d01 to
713034f
Compare
penelopeysm
force-pushed
the
py/actually-use-init
branch
from
a392451 to
12d93e5
Compare
penelopeysm
force-pushed
the
py/remove-samplingcontext
branch
from
713034f to
45a97ee
Compare
penelopeysm
force-pushed
the
py/actually-use-init
branch
from
12d93e5 to
7a8e7e3
Compare
penelopeysm
force-pushed
the
py/remove-samplingcontext
branch
from
45a97ee to
e817d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: Adding
hasvalueandgetvalueto AbstractPPLPart 2: Removing
hasvalueandgetvaluefrom DynamicPPLPart 3: Introducing
InitContextandinit!!Part 4: Using
ParamsInitto implementpredict,returned, andinitialize_valuesThis is part 5/N of #967.
Warning
This PR modifies
DebugUtils, so there will almost certainly be conflicts with #976.This PR removes everything that is no longer needed.
SamplingContext,SampleFromPrior,SampleFromUniform, now have direct one-to-one replacements (albeit with slightly different behaviour since they now always overwrite variables in the varinfo).It also removes
assumeandtilde_assume.Prior to this PR we had two different kinds of
assume, one with a sampler and one without. Now we only have the one without, so we can just move that definition intotilde_assume(::DefaultContext, ...).Finally,
tilde_assume!!has been removed as we can just dispatch on the type ofright. (Previously this wasn't possible because there was a lot of stuff aboutis_rhs_model, etc. etc. which was removed in #960.)Closes #859
Closes #955