Fix benign circularity, add CI check

Author: Gerrit0

.github/workflows/ci.yml

@@ -31,7 +31,10 @@ jobs:
             - name: Circular dependency check
               uses: gerrit0/circular-dependency-check@v2.0.2
               with:
-                  entry: dist/index.js
+                  entry: >
+                    dist/index.js
+                    dist/lib/models/index.js
+                    dist/browser-utils.js
     build-release:
         runs-on: ubuntu-latest
         name: Node 22 Release

src/lib/models/ProjectReflection.ts

@@ -9,11 +9,14 @@ import type { TypeParameterReflection } from "./TypeParameterReflection.js";
 import { ReflectionKind } from "./kind.js";
 import { Comment, type CommentDisplayPart } from "./Comment.js";
 import { ReflectionSymbolId } from "./ReflectionSymbolId.js";
-import { type Deserializer, JSONOutput, type Serializer } from "#serialization";
+import type { Deserializer, JSONOutput, Serializer } from "#serialization";
 import { assertNever, DefaultMap, i18n, type NormalizedPath, removeIfPresent, StableKeyMap } from "#utils";
 import type { DocumentReflection } from "./DocumentReflection.js";
 import type { FileRegistry } from "./FileRegistry.js";
 
+// Keep this in sync with JSONOutput.SCHEMA_VERSION
+export const JSON_SCHEMA_VERSION = "2.0";
+
 /**
  * A reflection that represents the root of the project.
  *
@@ -391,7 +394,7 @@ export class ProjectReflection extends ContainerReflection {
         });
 
         return {
-            schemaVersion: JSONOutput.SCHEMA_VERSION,
+            schemaVersion: JSON_SCHEMA_VERSION,
             ...super.toObject(serializer),
             variant: this.variant,
             packageName: this.packageName,

src/lib/models/index.ts

@@ -5,7 +5,7 @@ export * from "./DocumentReflection.js";
 export * from "./FileRegistry.js";
 export * from "./kind.js";
 export * from "./ParameterReflection.js";
-export * from "./ProjectReflection.js";
+export { ProjectReflection } from "./ProjectReflection.js";
 export * from "./ReferenceReflection.js";
 export * from "./Reflection.js";
 export * from "./ReflectionCategory.js";

src/lib/serialization/schema.ts

@@ -32,6 +32,7 @@
 import type * as M from "#models";
 import type { IfInternal, NormalizedPath } from "#utils";
 
+// Keep this in sync with JSON_SCHEMA_VERSION in ProjectReflection.ts
 export const SCHEMA_VERSION = "2.0";
 
 /**

src/lib/utils-common/index.ts

@@ -8,7 +8,6 @@ export * from "./events.js";
 export * from "./general.js";
 export * from "./hooks.js";
 export * from "./i18n.js";
-export * from "./index.js";
 export * as JSX from "./jsx.js";
 export * from "./logger.js";
 export * from "./map.js";

src/test/project.test.ts

@@ -1,5 +1,6 @@
-import { splitUnquotedString } from "../index.js";
+import { JSONOutput, splitUnquotedString } from "../index.js";
 import Assert from "assert";
+import { JSON_SCHEMA_VERSION } from "../lib/models/ProjectReflection.js";
 
 describe("Project", function () {
     describe("splitUnquotedString", () => {
@@ -32,4 +33,8 @@ describe("Project", function () {
             Assert.strictEqual(result[1], "d", "Wrong split");
         });
     });
+
+    describe("JSON schema version", () => {
+        Assert.strictEqual(JSON_SCHEMA_VERSION, JSONOutput.SCHEMA_VERSION);
+    });
 });