allow system luabins #228
Open
allow system luabins #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm hesitant to merge this until I can figure out what the local version is and whether it has any changes. I don't know why it was initially vendored. |
|
luabins is abandoned https://github.com/agladysh/luabins (repository archived) and Aegisub already has fixes on the vendored source code: 8d8ea16 Package maintainers can create a luabins package from Aegisub's source tree though. |
This is convoluted way to develop a package... in subproject directory. If this luabins should be packages it should be forked as TypesettingTools/luabins with proper release with the needed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #225. It shouldn't have been in that PR because it's unrelated.