Skip to content

Conversation

arch1t3cht
Copy link
Member

PR created to test the CI first.

These aren't too essential for testing and cause lots of headaches
in automated build setups (e.g. `meson setup --wipe`, `meson dist`,
and probably also many distro build scripts).
@guijan
Copy link
Contributor

guijan commented Dec 30, 2024

meson dist --include-subprojects -C build doesn't guarantee that all subprojects are included, only the ones used. Maybe it would be a good idea to add a test that extracts the tarball and checks if a file from each subproject exists?

@arch1t3cht arch1t3cht force-pushed the meson_dist branch 2 times, most recently from 1ef3603 to 7b48edc Compare December 30, 2024 20:57
Tarballs will not include a git repository, so git_version.h cannot be
generated from them. When meson dist is run, no build folder exists yet,
so copy the generated git_version.h into the root source folder and make
version.sh copy it to the build folder if present.
@arch1t3cht
Copy link
Member Author

Good idea, done (or, well, attempted. Debugging CI workflows is annoying.)

@arch1t3cht arch1t3cht force-pushed the meson_dist branch 4 times, most recently from 15eed0e to 4b2cbaa Compare December 30, 2024 22:22
@arch1t3cht arch1t3cht merged commit 89e62b0 into master Dec 30, 2024
6 of 7 checks passed
@arch1t3cht arch1t3cht deleted the meson_dist branch December 30, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants