Skip to content

Conversation

KerimDemirkaynak
Copy link
Contributor

@KerimDemirkaynak KerimDemirkaynak commented Mar 21, 2025

I fixed some minor typos, added missing strings, and resolved issue #314.

@arch1t3cht
Copy link
Member

I'm not a fan of manually adding strings to tr.po, this will make it harder to maintain in the future. In particular, the string for the help button mentioned in #314 should not be added to Aegisub's catalog - this string is used inside wxWidgets, not in Aegisub itself, and wxWidgets could update its usage at any time and break the translation (like it already has once).
If strings are missing, they should be accounted for in make_pot.sh so that they're automatically added to the pot file, and hence to the po files. If you see missing strings you can make issues for them (but the #314 one may take a while to complete).

I can merge the updates to the existing strings if you isolate those changes.

@KerimDemirkaynak
Copy link
Contributor Author

Done.

@arch1t3cht
Copy link
Member

Can you squash the commits to a single one and force push (or are you fine with me doing that)?

@KerimDemirkaynak
Copy link
Contributor Author

I'd appreciate it if you could do it, I don't know much about GitHub.

@arch1t3cht arch1t3cht merged commit ef18d55 into TypesettingTools:master May 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants