Miscellaneous changes #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0tkl
force-pushed
the
miscfix
branch
4 times, most recently
from
b033844 to
0a41d2f
Compare
arch1t3cht
reviewed
Jun 9, 2025
src/command/command.h
Outdated
| #define CMD_TYPE(a) int Type() const override { using namespace cmd; return a; } | ||
|
|
||
| #define CMD_ICON(icon) wxBitmapBundle Icon(int height, wxLayoutDirection dir = wxLayout_LeftToRight) const override { \ | ||
| #define CMD_ICON(icon) wxBitmapBundle Icon(int height, wxLayoutDirection dir) const override { \ |
There was a problem hiding this comment.
Is this really correct? cppreference says
The overriders of virtual functions do not acquire the default arguments from the base class declarations, and when the virtual function call is made, the default arguments are decided based on the static type of the object.
Seeing as this compiles, it looks like this function is never actually called on a [variable whose static type is a] derived command class, but it sounds possible that this could be wanted at some point in the future (say you wanted to also show the icon of a specific command elsewhere).
There was a problem hiding this comment.
Dropped from PR for further discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick my recent commits from local repo, which I built for my own use.
The first commit, fix combine-config.py, is a bugfix. My local build will failed if this commit is not applied.
The next two commits, remove override functions and add missing headers, are cosmetic changes to actual code.
The rest of commits are cosmetic changes to comments and documentation.