Add GitHub Action to Validate Website Build on All Branches #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPDonaghy
reviewed
Apr 27, 2025
| @@ -0,0 +1,29 @@ | |||
| name: Website Build Check | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
Hey Jordan, my suggestion is we restrict what triggers this workflow a bit more.
My thinking is that it should only run when files related to the website have been changed.
I did this for the Docs Site workflow and it really sped things up for PRs and pushes that didn't involve docs src files.
What are your thoughts?
There was a problem hiding this comment.
Yes I completely agree, this would be a lot more efficient. Will add this change
| push: | ||
| branches: | ||
| - main | ||
| - '**' |
There was a problem hiding this comment.
I also don't think it should run on pushes to any other branch than main since being triggered on pull requests should catch anything before we merge it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a GitHub Actions workflow to automatically build the website for every commit and push.
This workflow ensures that the website is always in a buildable state by running npm run build, catching any type errors, lint issues, or build failures early during development.
It triggers on pushes to main as well as to any branches branching off main.
Verification
Resources