Skip to content

Move model specific class members from layout.h to the 911 and Neuro specific sub-classes. #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jardiamj opened this issue Nov 27, 2021 · 2 comments
Labels
architecture cleanup good first issue Good for newcomers refactor doesn't change functionality, just improves code

Comments

@jardiamj
Copy link
Contributor

The file: /Simulator/Layouts/Layout.h contains 911 and Neuron specific class members. The 911 specific members are only used for initialization so these can be moved to layout911.h:

   BGSIZE numCallerVertices_
   ...

   vector<int> callerVertexList_;    ///< Caller vertex list.

   vector<int> psapVertexList_;    ///< PSAP vertex list.
   
   vector<int> responderVertexList_;    ///< Responder vertex list.

The Neuron specific class members are being used in the implementation of printParameters() for printing to the logging file. It seems to me that, since these parameters are model specific, the printParameters() method could be an abstract method to be implemented by the model specific sub-classes, the same way we are doing it with loadParameters().

layout.h Neuro specific class members:

   vector<int> probedNeuronList_;
   ...
   BGSIZE numEndogenouslyActiveNeurons_;
   ...
   vector<int> endogenouslyActiveNeuronList_;    ///< Endogenously active neurons list.

   vector<int> inhibitoryNeuronLayout_;    ///< Inhibitory neurons list.
@jardiamj jardiamj added cleanup good first issue Good for newcomers labels Nov 27, 2021
@stiber
Copy link
Contributor

stiber commented Nov 29, 2021

I think that the probedNeuronList_ could be renamed probedVertexList_ and kept at the top level. Actually, I believe that this is going to be/is being moved to the Recorder classes, right, @kimjamesuw?

@stiber
Copy link
Contributor

stiber commented Apr 29, 2025

See also #843

@stiber stiber added the refactor doesn't change functionality, just improves code label Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture cleanup good first issue Good for newcomers refactor doesn't change functionality, just improves code
Projects
None yet
Development

No branches or pull requests

2 participants