Move an fclose() to after cleaup_results which avoids left open file pointers.

jke000 · jke000 · commit 4181df6987a4 · 2025-03-14T16:12:22.000-07:00
diff --git a/CometSearch/CometSearchManager.cpp b/CometSearch/CometSearchManager.cpp
@@ -3664,9 +3664,9 @@ bool CometSearchManager::DoSingleSpectrumSearchMultiResults(const int topN,
       scores.push_back(score);
    }
 
-   fclose(fpdb);  //FIX: would be nice to not fopen/fclose with each query
+cleanup_results:
 
-   cleanup_results:
+   fclose(fpdb);  //FIX: would be nice to not fopen/fclose with each query
 
    // Deleting each Query object in the vector calls its destructor, which
    // frees the spectral memory (see definition for Query in CometDataInternal.h).

Original file line number	Diff line number	Diff line change
`@@ -3664,9 +3664,9 @@ bool CometSearchManager::DoSingleSpectrumSearchMultiResults(const int topN,`
`3664`	`3664`	`scores.push_back(score);`
`3665`	`3665`	`}`
`3666`	`3666`
`3667`		`- fclose(fpdb); //FIX: would be nice to not fopen/fclose with each query`
	`3667`	`+cleanup_results:`
`3668`	`3668`
`3669`		`- cleanup_results:`
	`3669`	`+ fclose(fpdb); //FIX: would be nice to not fopen/fclose with each query`
`3670`	`3670`
`3671`	`3671`	`// Deleting each Query object in the vector calls its destructor, which`
`3672`	`3672`	`// frees the spectral memory (see definition for Query in CometDataInternal.h).`