Skip to content

Commit cb56a4d

Browse files
committed
nits
1 parent a161834 commit cb56a4d

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

rest/src/test/scala/io/udash/rest/RestApiTest.scala

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import io.udash.rest.raw.RawRest.HandleRequest
88
import monix.eval.Task
99
import monix.execution.Scheduler
1010
import org.scalactic.source.Position
11-
import org.scalatest.concurrent.PatienceConfiguration.Timeout
1211
import org.scalatest.concurrent.ScalaFutures
1312
import org.scalatest.funsuite.AnyFunSuite
13+
import org.scalatest.time.{Millis, Seconds, Span}
1414

1515
import scala.concurrent.duration.FiniteDuration
1616

@@ -21,7 +21,7 @@ abstract class RestApiTest extends AnyFunSuite with ScalaFutures {
2121

2222
implicit def scheduler: Scheduler = Scheduler.global
2323

24-
private val impl: RestTestApi = RestTestApi.Impl
24+
private val impl: RestTestApi = RestTestApi.impl()
2525

2626
final val serverHandle: RawRest.HandleRequest =
2727
RawRest.asHandleRequest[RestTestApi](impl)
@@ -47,6 +47,8 @@ abstract class RestApiTest extends AnyFunSuite with ScalaFutures {
4747
}
4848

4949
trait RestApiTestScenarios extends RestApiTest {
50+
override implicit val patienceConfig: PatienceConfig = PatienceConfig(scaled(Span(10, Seconds)), scaled(Span(50, Millis)))
51+
5052
test("trivial GET") {
5153
testCall(_.trivialGet)
5254
}
@@ -110,7 +112,7 @@ trait RestApiTestScenarios extends RestApiTest {
110112
.traverse(List.range(0, Connections))(_ => Task.deferFuture(proxy.neverGet).timeout(CallTimeout).failed)
111113
.map(_ => assertResult(expected = Connections)(actual = getNeverGetCounter())) // neverGet should be called Connections times
112114
.runToFuture
113-
.futureValue(Timeout(30.seconds))
115+
.futureValue
114116
}
115117

116118
test("close connection on monix task cancellation") {
@@ -124,7 +126,7 @@ trait RestApiTestScenarios extends RestApiTest {
124126
}
125127
.map(_ => assertResult(expected = Connections)(actual = getNeverGetCounter())) // neverGet should be called Connections times
126128
.runToFuture
127-
.futureValue(Timeout(30.seconds))
129+
.futureValue
128130
}
129131
}
130132

rest/src/test/scala/io/udash/rest/RestTestApi.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ object RestTestApi extends DefaultRestApiCompanion[RestTestApi] {
179179

180180
import Scheduler.Implicits.global
181181

182-
def Impl: RestTestApi = new RestTestApi {
182+
def impl(): RestTestApi = new RestTestApi {
183183
def trivialGet: Future[Unit] = Future.unit
184184
def failingGet: Future[Unit] = Future.failed(HttpErrorException.plain(503, "nie"))
185185
def jsonFailingGet: Future[Unit] = Future.failed(HttpErrorException(503, HttpBody.json(JsonValue(JsonStringOutput.write(ErrorWrapper("nie"))))))

0 commit comments

Comments
 (0)