Skip to content

Columns are matched by field key rather than label #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mismaah opened this issue Jun 4, 2024 · 1 comment
Open

Columns are matched by field key rather than label #258

mismaah opened this issue Jun 4, 2024 · 1 comment
Labels
v5 Will be solved in v5

Comments

@mismaah
Copy link

mismaah commented Jun 4, 2024

In the MatchColumns step, when matches are found using Levenstein distance, the field.key is passed to the lavenstein function instead of field.label. According to the readme, the label is used for matching columns. So either the findMatch function is wrong or the readme is wrong. If it's the former, I have opened a PR for it.

@pablogtab-terrand
Copy link

pablogtab-terrand commented Aug 8, 2024

I think you are right
Note: you could use the field.alternateMatches property and pass the field.label there also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Will be solved in v5
Projects
None yet
Development

No branches or pull requests

3 participants