Skip to content

Update to xunit 3 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

Update to xunit 3 #297

merged 2 commits into from
Jul 6, 2025

Conversation

ChrisDoernen
Copy link
Contributor

Updated packages to new major version of xunit. Unit tests succeed but I dont know if the changes, especially in TestPriorityOrderer are sufficient. There are null reference warnings because properties of ITestCase are nullable.

I also have no idea what strategy would be best in terms of versioning. Xunit chose to publish completely new packages...

@Arash-Sabet
Copy link
Contributor

@ChrisDoernen I am going to review it.

@Arash-Sabet Arash-Sabet self-requested a review July 6, 2025 13:50
@Arash-Sabet Arash-Sabet linked an issue Jul 6, 2025 that may be closed by this pull request
@Arash-Sabet Arash-Sabet self-assigned this Jul 6, 2025
@Arash-Sabet Arash-Sabet added the bug Something isn't working label Jul 6, 2025
@Arash-Sabet Arash-Sabet linked an issue Jul 6, 2025 that may be closed by this pull request
Bump Microsoft.Extensions.* and Microsoft.NET.Test.Sdk package versions to latest patch releases in both main and example projects. Update Azure Pipelines to use .NET SDK 9.0.301 and increment revision. Improve null safety and type resolution in TestPriorityOrderer, and update example tests to use cancellation tokens with Task.Delay.
@Arash-Sabet Arash-Sabet merged commit 7ad964c into Umplify:main Jul 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test ordering throws an exception Upgrade all NuGet packages
2 participants