Make naturals, integers, integer fractions, and rationals consistent about some inequality theorems #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... this is the kind of pull request that is probably going to be problematic with #1211, because I'm already doing a lot of the standardization work there. |
|
Would skipping the parts of this PR that rename existing things help? I would certainly recommend breaking #1211 into more incremental changes like this one. |
|
I think I'd rather improve the naming in #1211 than here in this pull request, because I can make more comprehensive naming changes there that align everything in a coherent way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to standardize on the naming scheme established by
decide-le-leq-ℚandnot-leq-le-ℚacross elementary number types.