Skip to content

Monotonic sequences in posets #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 63 commits into from
Apr 22, 2025

Conversation

malarbol
Copy link
Collaborator

@malarbol malarbol commented Mar 28, 2025

This PR introduces a few definitions and results to work with sequences is preorders, posets or strictly preordered sets.
As an application, it introduces the concept of subsequences of a sequence u: the sequences u ∘ f for some strictly increasing map f : ℕ → ℕ.

@malarbol malarbol marked this pull request as draft March 28, 2025 17:51
@malarbol
Copy link
Collaborator Author

There's still a lot to do but if anyone sees anything they dislike, we can start talking about it.
For example, should I use nondecreasing / increasing instead of increasing / strictly increasing ?

Co-authored-by: Fredrik Bakke <fredrbak@gmail.com>
@malarbol
Copy link
Collaborator Author

Is it problematic to merge this PR without #1371? It is helpful to me to portion the review job out a bit (2700 lines is a lot for me)

On the contrary! That's why I kept it separated from #1371. I think it's' self-contained enough to be merged on its own and it will make #1371 2/3 lighter, so easier to review later. I'm actually doing last-minute additions there too but it's ok to merge this now and I'll make the necessary changes in #1371 for a new review.

@malarbol
Copy link
Collaborator Author

I added a few modules on bounded sequences. I still haven't find a good name for sequences tending to infinity so I'd rather leave this for later. Otherwise, I think it's good to go.

@fredrik-bakke
Copy link
Collaborator

I added a few modules on bounded sequences. I still haven't find a good name for sequences tending to infinity so I'd rather leave this for later. Otherwise, I think it's good to go.

Were these files suggested in the previous review?
If not, please pull them out to a second PR so this one can be merged.

@fredrik-bakke fredrik-bakke marked this pull request as draft April 22, 2025 13:18
@fredrik-bakke fredrik-bakke marked this pull request as ready for review April 22, 2025 13:19
@malarbol
Copy link
Collaborator Author

Were these files suggested in the previous review? If not, please pull them out to a second PR so this one can be merged.

Not really. At some point I wanted to use them to talk about unbounded sequences / sequences tending to infinity but I didn't went through. They're out now.

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fredrik-bakke fredrik-bakke merged commit 0985566 into UniMath:master Apr 22, 2025
4 checks passed
@malarbol malarbol mentioned this pull request Apr 22, 2025
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants