-
Notifications
You must be signed in to change notification settings - Fork 82
Refactor metric spaces #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
malarbol
wants to merge
60
commits into
UniMath:master
Choose a base branch
from
malarbol:refactor-metric-spaces-next
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor metric spaces #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jun 27, 2025
Draft
…ions is an isometric equivalence
…y approximations (constant cauchy approximations)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the metric space module (#1421)
remove the notion of
Premetric
/Premetric-Space
:as we discussed, the term "premetric" has too many different meanings to be reliably used in this library. What was called a
Premetric
is now aRational-Neighborhood-Relation
and we only focus on (pseudo)metric spaces.all (pseudo)metric spaces are saturated:
including saturation in the definition of pseudometric space is coherent with the definition of Richman premetric spaces and makes a lot of things easier (e.g.: the limit map is short, the metric space of Cauchy approximations in a complete metric space is complete, etc.).
simplify hierarchy in concepts (define things for for metric spaces first, instead of the splitting premetric>pseudometric>metric):
although a lot of concepts only depend on the underlying neighborhood relation, they are principally useful for (pseudo)metric spaces. We prioritized definitions on metric spaces, which is where they're the most useful; if we need the corresponding concepts for pseudometric spaces, we can add them later. (e.g. we'll probably want
isometry-Pseudometric-Space
at some point but I think this PR is already big enough).