-
Notifications
You must be signed in to change notification settings - Fork 438
chore: parallelize testing in ci with xdist #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Obviously something wonky going on with the coverage but as a POC I think this works (tests run, and they run much faster). I think we would need to use ^ did this |
Removed '--cov-branch' from default pytest arguments.
For that part of the issue, you could mark the plotting tests, run the non-plotting tests in parallel then the plotting tests serially. MetPy probably has enough non-plotting tests this would speed things up |
|
@DWesl it actually seemed to be working alright - |
Description Of Changes
From an idea in here: #3901
Attempting to turn on parallel testing in CI to speed up testing. Locally testing it seemed to work but who knows once it gets in the wild.
Definite DISadvantage here is that it screws up pluggy, but that's only really relevant when running locally anyways and it's not enabled by default. Another possible issue is that matplotlib is not thread safe, so I am not sure how tests will interact with that, it could end up being more flaky than it's worth.
Checklist