Skip to content

Fix usages feature: filter callers by location #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saloed merged 1 commit into from
Apr 15, 2025
Merged

Fix usages feature: filter callers by location #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jacodb-core/src/main/kotlin/org/jacodb/impl/features/Usages.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import org.jacodb.impl.storage.defaultBatchSize
import org.jacodb.impl.storage.dslContext
import org.jacodb.impl.storage.eqOrNull
import org.jacodb.impl.storage.ers.filterDeleted
import org.jacodb.impl.storage.ers.filterLocations
import org.jacodb.impl.storage.ers.toClassSource
import org.jacodb.impl.storage.execute
import org.jacodb.impl.storage.executeQueries
Expand Down Expand Up @@ -279,11 +280,12 @@ object Usages : JcFeature<UsageFeatureRequest, UsageFeatureResponse> {
val locationId = callee.getCompressed<Long>("locationId")!!
callee.getLinks("calls").map { it to locationId }
}
.map { (call, _) ->
.map { (call, callerLocationId) ->
val callerId = call.getCompressedBlob<Long>("callerId")!!
val caller = symbolInterner.findSymbolName(callerId)!!
val clazz = txn.find("Class", "nameId", callerId.compressed)
.filterDeleted()
.filterLocations(callerLocationId)
.first()
val classId = clazz.id.instanceId
UsageFeatureResponse(
Expand Down
Loading