Skip to content

Support EnumValueType#321

Merged
Lipen merged 4 commits intoneofrom
lipen/enum-type
May 30, 2025
Merged

Support EnumValueType#321
Lipen merged 4 commits intoneofrom
lipen/enum-type

Conversation

@Lipen
Copy link
Copy Markdown
Member

@Lipen Lipen commented May 30, 2025

This PR adds EtsEnumValueType and supports its deserialization from JSONa (adds DTO, updates the converter).

@Lipen Lipen requested a review from CaelmBleidd May 30, 2025 13:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2025

Test results on JDK 8

 72 files  ±0   72 suites  ±0   5m 4s ⏱️ +6s
633 tests ±0  620 ✅ ±0  13 💤 ±0  0 ❌ ±0 
705 runs  ±0  692 ✅ ±0  13 💤 ±0  0 ❌ ±0 

Results for commit a96cfa0. ± Comparison against base commit 126a4e8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2025

Test results on JDK 19

 72 files  ±0   72 suites  ±0   4m 52s ⏱️ -3s
633 tests ±0  623 ✅ ±0  10 💤 ±0  0 ❌ ±0 
705 runs  ±0  695 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit a96cfa0. ± Comparison against base commit 126a4e8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2025

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 30s ⏱️ +2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit a96cfa0. ± Comparison against base commit 126a4e8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 30, 2025

Test results on JDK 11

 72 files  ±0   72 suites  ±0   5m 29s ⏱️ -7s
633 tests ±0  625 ✅ ±0  8 💤 ±0  0 ❌ ±0 
705 runs  ±0  697 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a96cfa0. ± Comparison against base commit 126a4e8.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (126a4e8) to head (db14b65).
Report is 1 commits behind head on neo.

Files with missing lines Patch % Lines
...b-ets/src/main/kotlin/org/jacodb/ets/model/Type.kt 37.50% 5 Missing ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dto/Types.kt 40.00% 3 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #321      +/-   ##
============================================
- Coverage     70.63%   70.58%   -0.05%     
+ Complexity     2460     2457       -3     
============================================
  Files           275      275              
  Lines         15268    15284      +16     
  Branches       2267     2269       +2     
============================================
+ Hits          10784    10788       +4     
- Misses         3569     3577       +8     
- Partials        915      919       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lipen Lipen merged commit 4ca8d08 into neo May 30, 2025
4 checks passed
@Lipen Lipen deleted the lipen/enum-type branch May 30, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants