fix: filter object env vars in fork mode and fix CLI option mapping#6082
Open
amussara wants to merge 1 commit intoUnitech:masterfrom
Open
fix: filter object env vars in fork mode and fix CLI option mapping#6082amussara wants to merge 1 commit intoUnitech:masterfrom
amussara wants to merge 1 commit intoUnitech:masterfrom
Conversation
Fixes Unitech#6073: PM2 passes object properties as '[object Object]' environment variables to subprocesses in fork mode. Added sanitizeProcessEnv() function that filters out non-primitive values (objects, arrays) before passing env to child_process.spawn(). Fixes Unitech#5208: --stop-exit-codes CLI option was not recognized because Config.filterOptions() only checked explicit schema aliases. Enhanced filterOptions() with snakeToCamel() helper to automatically map commander.js camelCase options (e.g. stopExitCodes) to their snake_case schema keys (e.g. stop_exit_codes). This fixes all CLI options with hyphens that correspond to underscore-separated schema keys. Also added explicit 'stopExitCodes' alias to the stop_exit_codes schema entry for additional clarity.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6073: PM2 passes object properties as '[object Object]' environment variables to subprocesses in fork mode. Added sanitizeProcessEnv() function that filters out non-primitive values (objects, arrays) before passing env to child_process.spawn().
Fixes #5208: --stop-exit-codes CLI option was not recognized because Config.filterOptions() only checked explicit schema aliases. Enhanced filterOptions() with snakeToCamel() helper to automatically map commander.js camelCase options (e.g. stopExitCodes) to their snake_case schema keys (e.g. stop_exit_codes). This fixes all CLI options with hyphens that correspond to underscore-separated schema keys.
Also added explicit 'stopExitCodes' alias to the stop_exit_codes schema entry for additional clarity.