Skip to content

Conversation

Pauliusd01
Copy link
Collaborator

@Pauliusd01 Pauliusd01 commented Aug 21, 2024

Description

Disabled tvOS CI from running on 6000 and 22.3 due to the instabilities.

Risk

The risk is that tvOS could have issues without the CI catching it. But that's already the thing with it always failing

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01 Pauliusd01 changed the title Update config.metadata CHANGE: Disable tvOS CI on 6000 Aug 21, 2024
@Pauliusd01 Pauliusd01 added the work in progress Indicates that the PR is work in progress and any review efforts can be post-poned. label Aug 21, 2024
@Pauliusd01 Pauliusd01 changed the title CHANGE: Disable tvOS CI on 6000 CHANGE: Disable tvOS CI on 6000 and 22.3 Aug 21, 2024
@Pauliusd01 Pauliusd01 requested a review from stefanunity August 22, 2024 05:31
@Pauliusd01 Pauliusd01 changed the title CHANGE: Disable tvOS CI on 6000 and 22.3 CHANGE: Disable tvOS CI on 6000 and 22.3 (ISXB-879) Aug 22, 2024
@Pauliusd01 Pauliusd01 removed the work in progress Indicates that the PR is work in progress and any review efforts can be post-poned. label Aug 22, 2024
@Pauliusd01
Copy link
Collaborator Author

@stefanunity hey I was told to disable these but maybe a better approach would be to make them not required to merge instead. But I don't know how to do that 😓 Would appreciate your thoughts on this

Copy link
Collaborator

@stefanunity stefanunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rest see DM

@Pauliusd01 Pauliusd01 merged commit 41a977c into develop Aug 22, 2024
@Pauliusd01 Pauliusd01 deleted the disable-tvos-6000 branch August 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants