Skip to content

Conversation

LeoUnity
Copy link
Collaborator

@LeoUnity LeoUnity commented Sep 4, 2025

Description

The code block was missing the ``` ending, so the paragraphs afterwards were still considered code.

Before:
image

After:
image

Testing status & QA

None yet.

Overall Product Risks

  • Complexity: 0
  • Halo Effect: 0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@LeoUnity LeoUnity changed the title Code block was missing ending Docs: Using Processors page was missing a code block ending Sep 4, 2025
@LeoUnity LeoUnity changed the title Docs: Using Processors page was missing a code block ending DOCS: Using Processors page was missing a code block ending Sep 4, 2025
@LeoUnity LeoUnity marked this pull request as ready for review September 4, 2025 13:33
@Pauliusd01
Copy link
Collaborator

Pauliusd01 commented Sep 4, 2025

Does this fix only the top half of the example code? Seems like the bottom is broken as well
image

@LeoUnity
Copy link
Collaborator Author

LeoUnity commented Sep 4, 2025

Yeah it's supposed to fix exactly that part, this is what it looks for me:
image
I followed the instructions in https://internaldocs.unity.com/package_development/documentation/#previewing-package-docs to get the preview locally. I'm wondering if I'm doing something different than you...

I also updated the PR description to include the before and after

@Pauliusd01
Copy link
Collaborator

Pauliusd01 commented Sep 5, 2025

I followed the instructions in https://internaldocs.unity.com/package_development/documentation/#previewing-package-docs to get the preview locally. I'm wondering if I'm doing something different than you...

I also updated the PR description to include the before and after

Sorry for the scare, the local doc version failed to build for me so I only peeked at the public one. I fixed the local doc one now, was missing a visual studio component. Looks good to me

Copy link
Collaborator

@ritamerkl ritamerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, how did that happen? Thanks for the fix!

@codecov-github-com
Copy link

codecov-github-com bot commented Sep 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff             @@
##           develop    #2232      +/-   ##
===========================================
- Coverage    68.14%   66.53%   -1.62%     
===========================================
  Files          367      376       +9     
  Lines        53685    55042    +1357     
===========================================
+ Hits         36584    36622      +38     
- Misses       17101    18420    +1319     
Flag Coverage Δ
inputsystem_Windows_2021.3 5.91% <ø> (?)
inputsystem_Windows_6000.0 5.19% <ø> (?)
inputsystem_Windows_6000.2 5.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LeoUnity LeoUnity merged commit fabe22a into develop Sep 19, 2025
13 checks passed
@LeoUnity LeoUnity deleted the manual-processor-codeblock-end-fix branch September 19, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants