-
Notifications
You must be signed in to change notification settings - Fork 329
DOCS: Using Processors page was missing a code block ending #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yeah it's supposed to fix exactly that part, this is what it looks for me: I also updated the PR description to include the before and after |
Sorry for the scare, the local doc version failed to build for me so I only peeked at the public one. I fixed the local doc one now, was missing a visual studio component. Looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, how did that happen? Thanks for the fix!
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2232 +/- ##
===========================================
- Coverage 68.14% 66.53% -1.62%
===========================================
Files 367 376 +9
Lines 53685 55042 +1357
===========================================
+ Hits 36584 36622 +38
- Misses 17101 18420 +1319
Flags with carried forward coverage won't be shown. Click here to find out more. see 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
The code block was missing the ``` ending, so the paragraphs afterwards were still considered code.
Before:

After:

Testing status & QA
None yet.
Overall Product Risks
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed
,Fixed
,Added
sections.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: