Skip to content

Conversation

LeoUnity
Copy link
Collaborator

Description

Please fill this section with a description what the pull request is trying to address and what changes were made.

Testing status & QA

Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@codecov-github-com
Copy link

codecov-github-com bot commented Sep 25, 2025

Codecov Report

Attention: Patch coverage is 9.86547% with 201 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../Actions/Interactions/MultiTapInteractionEditor.cs 0.00% 29 Missing ⚠️
...tor/Actions/Interactions/PressInteractionEditor.cs 0.00% 24 Missing ⚠️
...Controls/Processors/AxisDeadzoneProcessorEditor.cs 0.00% 17 Missing ⚠️
...ontrols/Processors/StickDeadzoneProcessorEditor.cs 0.00% 17 Missing ⚠️
...r/Actions/Interactions/SlowTapInteractionEditor.cs 0.00% 16 Missing ⚠️
...ditor/Actions/Interactions/TapInteractionEditor.cs 0.00% 16 Missing ⚠️
...itor/Actions/Interactions/HoldInteractionEditor.cs 0.00% 15 Missing ⚠️
....inputsystem/Editor/Actions/AxisCompositeEditor.cs 0.00% 14 Missing ⚠️
...putsystem/Editor/Actions/Vector2CompositeEditor.cs 0.00% 14 Missing ⚠️
...putsystem/Editor/Actions/Vector3CompositeEditor.cs 0.00% 14 Missing ⚠️
... and 5 more
@@             Coverage Diff             @@
##           develop    #2243      +/-   ##
===========================================
+ Coverage    68.14%   72.14%   +3.99%     
===========================================
  Files          367      550     +183     
  Lines        53685    98126   +44441     
===========================================
+ Hits         36584    70790   +34206     
- Misses       17101    27336   +10235     
Flag Coverage Δ
inputsystem_Windows_6000.2 6.43% <12.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sts/InputSystem.Editor/ControlSchemeEditorTests.cs 100.00% <100.00%> (ø)
Assets/Tests/InputSystem/CoreTests_Editor.cs 97.70% <ø> (ø)
...stem/Editor/AssetEditor/InputActionAssetManager.cs 66.39% <ø> (ø)
...tem/Editor/AssetEditor/InputActionEditorToolbar.cs 0.00% <ø> (ø)
...stem/Editor/AssetEditor/InputActionEditorWindow.cs 0.00% <ø> (ø)
...em/Editor/AssetEditor/InputActionPropertiesView.cs 0.00% <ø> (ø)
...utsystem/Editor/AssetEditor/InputActionTreeView.cs 50.20% <100.00%> (ø)
...tem/Editor/AssetEditor/InputActionTreeViewItems.cs 74.91% <ø> (ø)
...m/Editor/AssetEditor/InputBindingPropertiesView.cs 0.00% <ø> (ø)
...tem/Editor/AssetEditor/NameAndParameterListView.cs 0.00% <ø> (ø)
... and 93 more

... and 97 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants