Skip to content

Rule Descriptors Ids as strings are not comparing probably when checking if descriptor is enabled. #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schraf opened this issue Mar 6, 2024 · 0 comments

Comments

@schraf
Copy link

schraf commented Mar 6, 2024

Describe the bug
If you add a Rule entry into the Project Settings and set the Id As String to the rule you want to enable, it will not be enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Project Settings -> Project Auditor
  2. Add a Rule with Id As String of "PAA0007"
  3. Run an analysis with Assets enabled and at least one texture in the project
  4. Set a breakpoint in AnalysisContext::IsDescriptorEnabled
  5. Step into the Params.Rules.GetRule call and notice that the Equals call between the Descriptor instances will fail

Expected behavior
Rules that you place in the Project Settings will run.

Screenshots
Screenshot 2024-03-06 at 11 12 43 AM
Screenshot 2024-03-06 at 11 45 08 AM

Information (please complete the following information):

  • OS: Windows
  • Unity version: 2021.3.34
  • Project Auditor version: 0.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant