Skip to content

ArgumentOutOfRangeException Bugfix #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NiklasDerEchte
Copy link

MessageDeserializer.cs::Read(out string value) threw an error as soon as NaN values were present in the points of the mesh.
Zero values were therefore given and one was subtracted from them due to ROS2 conditions.
This resulted in negative becoming in a counting variable

grafik

grafik

Proposed change(s)

I kept the original programming and used a Math.Max() to ensure that the value does not exceed 0.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Test Configuration:

  • Unity Version: Unity 2021.3.32f1
  • Unity machine OS + version: Windows 10
  • ROS machine OS + version: Ubuntu 22.04, ROS2 Humble
  • ROS–Unity communication: ROS2 TCP Node

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

MessageDeserializer.cs::Read(out string value) threw an error as soon as NaN values were present in the points of the mesh.
Zero values were therefore given and one was subtracted from them due to ROS2 conditions.
This resulted in negative becoming in a counting variable
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jan 18, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants