-
Notifications
You must be signed in to change notification settings - Fork 279
Hardware interface for sending motion primitives to the robot via the Instruction Executor instead of trajectories #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…overflow error when launching
…calls (and moved some more code to the helper header)
…tware_version_major_>= 5) in transform_force_torque() since ur_driver_ is not available in the ur_state_helper.hpp
… case to fit the rest of the repo
…31415/ros2_motion_primitives_ur_driver_pkg to the Universal_Robots_ROS2_Driver
… the hardware interface can receive a new motion primitive — replaces the previous, more complex handling via execution_status
…unch.py and added if else for driver_type to load the right ros2_control.xacro file in ur.urdf.xacro
@urfeex I've now integrated the During the integration, I encountered the following issue: Both the To solve this, I register the void urcl::InstructionExecutor::registerTrajDoneCallback()
{
driver_->registerTrajectoryDoneCallback(
std::bind(&InstructionExecutor::trajDoneCallback, this, std::placeholders::_1));
} Let me know if you have any suggestions for a cleaner solution. |
And one more question: I’ve documented everything a bit in README_MotionPrimitive.md. Should I integrate that into README.md? Or put it somewhere else? Or should I just leave it as it is? |
…d rotation vector and dot euler angles
to motion_primitives_forward_controller::motion_primitives_forward_controller
…d to revert the change after the PRs are merged.
… multiple callbacks.
This PR extends the
ur_robot_driver
package with a hardware interface for sending motion primitives to the robot via the Instruction Executor instead of traditional trajectory execution.To reuse the state interface functionalities of the original hardware interface in the new
motion_primitive_ur_driver
, these functionalities have been refactored into a shared helper file:stateinterface_helper.hpp
.The implementation uses the
motion_primitives_forward_controller
, which is planned to be integrated into theros2_controllers
repository. (ros-controls/ros2_controllers#1636)Motion primitives are received by the controller using the
MotionPrimitive.msg
from theindustrial_robot_motion_interfaces
package. A modified version of this message is used here, which includes additional helper types:STOP_MOTION
: Interrupts current robot motion and clears the motion queue.MOTION_SEQUENCE_START
andMOTION_SEQUENCE_END
: Define a sequence block—primitives between these markers are grouped and executed as a single, blended motion sequence. This enables smooth transitions between individual primitives, unlike executing them one by one.This implementation also depends on a pending Pull Request in the
Universal_Robots_Client_Library
. This PR extends the Instruction Executor with support formovec
commands, which is required for executing circular Cartesian motions within this driver.I'd appreciate any feedback or suggestions – thanks in advance!