fix Dockerfile to build and install executable #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iripiri, Is there a reason you removed the multi-stage Docker build? With your change, the resulting image is considerably larger, as it includes The reasoning behind the multi-stage build that we separate the build dependencies from the final image. |
Signed-off-by: iripiri <ikoester@eonerc.rwth-aachen.de>
|
Hi @stv0g, the multi-stage build is back! It got lost during several different build issues and fixing attempts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @stv0g
the current master is not running (CrashLoopBackOff on startup) because the VILLAScontroller executable was not copied to the image.
This happened because I had been working with a development image which was mounting the code and I was doing pip install manually.