Skip to content

Conversation

pjungkamp
Copy link
Contributor

@pjungkamp pjungkamp commented May 5, 2025

TODO

  • R-GOOSE Receiver
  • R-GOOSE Publisher

@pjungkamp pjungkamp force-pushed the rgoose branch 3 times, most recently from 302b1df to e1fdd8b Compare May 8, 2025 16:00
@pjungkamp pjungkamp force-pushed the rgoose branch 4 times, most recently from 1abd170 to 3893d6d Compare July 15, 2025 17:11
@pjungkamp
Copy link
Contributor Author

@stv0g Would you be ok with the libiec61850 and lib60870 fixups for mbedtls support being in the default overlay until I manage to get these into nixpkgs?

@stv0g
Copy link
Contributor

stv0g commented Jul 16, 2025

@stv0g Would you be ok with the libiec61850 and lib60870 fixups for mbedtls support being in the default overlay until I manage to get these into nixpkgs?

Yes please 🙏🏻 I would favor velocity in this case, instead of beeing blocked by Nixpkgs maintainers.

@pjungkamp pjungkamp marked this pull request as ready for review July 16, 2025 10:03
@pjungkamp pjungkamp requested a review from n-eiling as a code owner July 16, 2025 10:03
@pjungkamp pjungkamp requested a review from stv0g July 16, 2025 10:03
@n-eiling
Copy link
Member

I am curious: Why are you adding noexcept(false) to functions?

@pjungkamp
Copy link
Contributor Author

I am curious: Why are you adding noexcept(false) to functions?

I prefer to use noexcept as a default for functions, but when I know that a function might throw, indicate that using nexcept(false). This should indicate to others that this function can throw and will need to be handled accordingly. Functions across VILLASnode aren't consistently annotated with noexcept, which means that I often find myself looking into the function definition to check whether a function might throw or not. noexcept(false) shows to the reader of the code that this function might throw and has been written with exception safety in mind.

@pjungkamp
Copy link
Contributor Author

@stv0g I consider this PR ready. Could you do another review? I think the failing pkg:docker: [debian, linux/arm64/v8, arm64, aarch64-linux-gnu, pi5] pipeline is not caused by this PR but rather by some broken cached state in the debian image on the Pi5.

Copy link
Contributor

@stv0g stv0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. Only some minor comments..

@pjungkamp pjungkamp force-pushed the rgoose branch 3 times, most recently from d543336 to 241f4a7 Compare July 23, 2025 12:51
@pjungkamp
Copy link
Contributor Author

@stv0g I consider this PR ready. Could you do another review? I think the failing pkg:docker: [debian, linux/arm64/v8, arm64, aarch64-linux-gnu, pi5] pipeline is not caused by this PR but rather by some broken cached state in the debian image on the Pi5.

@windrad6 just managed to fix it. The Pi 5 was out of storage and "Invalid GPG key" is surely an interesting way to communicate that. The problem was the lack of garbage collection of the Docker build cache. We've now pruned the cache and set up automatic garbage collection to prevent this in the future.

@stv0g stv0g enabled auto-merge (rebase) July 24, 2025 18:46
@stv0g stv0g disabled auto-merge July 24, 2025 18:46
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>
@stv0g stv0g merged commit 864f8b5 into master Aug 21, 2025
2 checks passed
@stv0g stv0g deleted the rgoose branch August 21, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants