Skip to content

Fixes OpenDSSC installation: correct find condition and add to linker path #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leonardocarreras
Copy link
Contributor

@leonardocarreras leonardocarreras commented May 10, 2025

The OpenDSCC installs in a non-usual path.

The current check with find will always install because is not looking into the path where it gets installed.

The symbols needed are not found by the linker, so this is added.

image

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
@stv0g
Copy link
Contributor

stv0g commented May 11, 2025

Hi @leonardocarreras,

I think this should already have been resolved by this change which I merged a few days ago:
8bc1fe2#diff-49cac9549226aeff7ab6461609d9afc6d8bec062d76414c79007b101d5c2eda6R68

I am not a big fan of modifying the linker search path in deps.sh, since this is mixing up concerns:
https://github.com/VILLASframework/node/pull/910/files#diff-3702afcced7ceb56a7ccf7ebb5f0cfd309d51c83ba2cc77786507b02635eb291R506

A better solution, would be to add some more patches to install the library in the correct location. Like we already do here with other patches for OpenDSSC:

for i in ${SOURCE_DIR}/patches/*-opendssc-*.patch; do patch --strip=1 --binary < "$i"; done

@leonardocarreras
Copy link
Contributor Author

Hi @stv0g! I understand your point, what happens is that when just installing villas dependencies with the script in your own machine or in a container, you do not realize that there is a problem until later (in my experience villas compiles, but does have a runtime problem)... I will then keep doing the same in the container for dpsim that uses villas...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants