A bit more shell-related settings

Author: lex-ibm

.devcontainer/Containerfile

@@ -10,6 +10,7 @@ RUN apt update && \
         libxkbfile-dev \
         libsecret-1-dev \
         qemu-user \
+        shellcheck \
         && \
     apt clean && \
     rm -rf /var/lib/apt/lists/* && \

.devcontainer/README.md

@@ -6,7 +6,8 @@ Create a `.env` on the root of the project with the following content:
 # .env
 GH_TOKEN=your_github_token
 npm_config_arch=your_architecture # Options are: x64, arm64, arm, riscv64, loong64, ppc64, and s390x
-_VSCODE_ARCH=your_vsc_architecture # Options are: x64, arm64, armhf, riscv64, loong64, ppc64le, and s390x
+VSCODE_ARCH=your_vsc_architecture # Options are: x64, arm64, armhf, riscv64, loong64, ppc64le, and s390x
+#                                   note that VSC removes variables starting with VSCODE_ from the environment.
 # DISABLE_QEMU=true # Uncomment this if you prefer not to use the QEMU step in postinstall.js
 # Any other environment variable you want the tasks to run with or that set the build environment to your desired output architecture
 ```

.devcontainer/devcontainer.json

@@ -27,22 +27,18 @@
         "ghcr.io/devcontainers/features/github-cli:1": {},
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
             "dockerDashComposeVersion": "none"
-        }
+        },
+        "ghcr.io/devcontainers-extra/features/shfmt:1": {}
     },
     // Uncomment if you have `sed` issues due to VirtFs
     // "mounts": [
     //     "type=volume,source=vscode-src,target=${containerWorkspaceFolder}/vscode"
     // ],
-    // These are better placed in the .env file
-    // "containerEnv": {
-    //     "npm_config_arch": "ppc64",
-    //     "_VSCODE_ARCH": "ppc64le"
-    // },
     "runArgs": [
         "--security-opt",
         "label=disable",
         "--env-file",
-        ".env" // a place to put your GH_TOKEN
+        "${localWorkspaceFolder}/.env"
     ],
     "capAdd": [
         "CAP_AUDIT_WRITE"
@@ -57,12 +53,19 @@
         // Configure properties specific to VS Code.
         "vscode": {
             // Set *default* container specific settings.json values on container create.
-            "settings": {},
+            "settings": {
+                "shellformat.path": "/usr/local/bin/shfmt",
+                "shellcheck.executablePath": "/usr/bin/shellcheck"
+            },
             // Add the IDs of extensions you want installed when the container is created.
             "extensions": [
                 "dbaeumer.vscode-eslint",
                 "ms-azuretools.vscode-docker",
-                "github.vscode-github-actions"
+                "github.vscode-github-actions",
+                "foxundermoon.shell-format",
+                "rogalmic.bash-debug",
+                "mads-hartmann.bash-ide-vscode",
+                "timonwong.shellcheck"
             ]
         }
     },

.vscode/tasks.json

@@ -6,7 +6,7 @@
       {
         "label": "Download latest stable-linux vscode artifact",
         "type": "shell",
-        "command": "gh run list --workflow stable-linux --branch master --limit 1 | awk '{print $7}' | xargs -I {} gh run download {} -n vscode && sudo tar -xvzf vscode.tar.gz && sudo chown -R vscode:vscode ./vscode/",
+        "command": "set -a && source .env || true && set +a && gh run list --workflow stable-linux --branch master --limit 1 | awk '{print $7}' | xargs -I {} gh run download {} -n vscode && sudo tar -xvzf vscode.tar.gz && sudo chown -R vscode:vscode ./vscode/",
         "group": {
           "kind": "none"
         },
@@ -24,7 +24,7 @@
       {
         "label": "Build Linux REH",
         "type": "shell",
-        "command": "VSCODE_ARCH=\"${_VSCODE_ARCH}\" ./build/linux/package_reh.sh",
+        "command": "set -a && source .env || true && set +a && ./build/linux/package_reh.sh",
         "group": {
           "kind": "build",
           "isDefault": false