Skip to content

Resource IDs should always be strings #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tpansino opened this issue Aug 7, 2019 · 0 comments · May be fixed by #76
Open

Resource IDs should always be strings #74

tpansino opened this issue Aug 7, 2019 · 0 comments · May be fixed by #76

Comments

@tpansino
Copy link
Contributor

tpansino commented Aug 7, 2019

Describe the bug
From https://jsonapi.org/format/#document-resource-object-identification:

Every resource object MUST contain an id member and a type member. The values of the id and type members MUST be strings.

To Reproduce
Create a basic model and endpoint with id = IntegerField(). Observe that the resulting endpoint ids are all JSON integers, not strings.

Expected behavior
Should be strings per spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug/74 Automatically convert id values to strings during serialization Vacasa/drf-jsonapi
1 participant
@tpansino