Always lowercase filenames in CUtlFilenameSymbolTable to fix loading packed files on Linux (fixes #865) #1350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tracked down in #865, loading packed files (e.g. from bsps & vpks) is often broken on community maps for Linux users (& servers!!!) leading to missing textures and broken model collisions.
Also reported at ValveSoftware/Source-1-Games#6868
I'm making this PR to bring more visibility to the cause and to hopefully be merged.
(The cause being that
CUtlFilenameSymbolTable
only lowercases filenames on Windows, which is called fromCZipPackFile::GetFileInfo()
to use a cached file-handle.)