-
-
Notifications
You must be signed in to change notification settings - Fork 547
1.21.1 mana infusion rebalance #4916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TheRealWormbo
wants to merge
7
commits into
VazkiiMods:1.21.1-porting
Choose a base branch
from
TheRealWormbo:1.21.1-mana-infusion-rebalance
base: 1.21.1-porting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
1.21.1 mana infusion rebalance #4916
TheRealWormbo
wants to merge
7
commits into
VazkiiMods:1.21.1-porting
from
TheRealWormbo:1.21.1-mana-infusion-rebalance
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additions: - cycle of nether stones (renewable netherrack through basalt generator) - missing flowers to flower cycle (the entire cycle may be going away later, though) Changes: - made sapling cycle as expensive as crop cycle - turned a couple of "inofficial" two-item cycles into actual cycle definitions - moved tuff and calcite to the end of the original stone cycle (i.e. converting from stone up to granite is unaffected) - rearranged the log and sapling cycles so "easy" and "hard" to farm tree types alternate (oak, birch, spruce, and jungle are considered "easy", due to their straight 1x1 growth options) Removals: - froglight cycle (vanilla players have no issues putting the three frog variants into a magma cube farm) - chiseled stone bricks recipe (it's a vanilla 2x2 crafting recipe) - fish cycle (fish availability has improved a lot since that was put into place) - berry cycle (all three items are reasonably easy to farm, although apple availability could be a bit better) - deepslate is no longer available via mana infusion (it was basically the entry point of the 1.17 cycle) - all conjuration recipes except leaves and short grass (those will follow eventually) Notably, all other conjuration catalyst recipes will eventually be removed as well, once Botania provides better options to obtain those items.
- currently a static chance of 5%, but that could be adjusted per horn type in the future and maybe even support external factors like enchantments on the horn or player attributes - Horn/Drum of the Wild/Canopy mine the block as if using shears (allows for automating short grass, fern, and leaves gathering) - Horn of the Covering mines blocks as if using a shovel - horns track "times used" stat for every round of block breaking where they break at least one block - horns track "times mined" stat for every block they break, whether they break it without tool or as though they apply the proper tool - drums track "times used" when they are hit by a player-owned mana burst and "times mined" like the corresponding horn - because it made sense in this context, the mana blaster tracks "times used" for each shot now
(i.e. not for mystical flower production)
…onjuration recipes (rebrand for conjuration catalyst pending, probably naming it "Deconstruction Catalyst") - scrub cycle and duplication of leaves and grass is obsolete with horn/drum of the wild/canopy being able to produce shears drops - move deconstruction recipes to conjuration catalyst - add more 2x2 block deconstruction recipes: - snow block -> snowball - nether bricks -> nether brick - dripstone block -> pointed dripstone - honeycomb block -> honeycomb - magma block -> magma cream - amethyst block -> amethyst shard - make deconstruction recipes lossy (drop 3 instead of 4 items) unless there is a vanilla way to losslessly deconstruct the block (e.g. shoveling clay/snow) - new lossless 3x3 deconstruction recipes: - bamboo block (only unstripped) -> bamboo - melon -> melon slice - new alchemy recipe: wart block -> 1 nether wart (too powerful if treated as deconstruction recipe) - special deconstruction recipes: - snow layer -> 1 snowball - red nether bricks -> 2 nether brick - amethyst bud/cluster -> 1..4 amethyst shard (depending on growth stage, costs comparable to wool deconstruction) - reorganized deconstruction recipe groups (quartz types get their own group, generic 2x2 lossless, 2x2 lossy, and 3x3 lossy recipes each get their own groups, amethyst cluster/bud recipes are grouped together)
(It's the logical choice due to the stone conversion recipe.)
There are still some open points to figure out, like:
(GoG item availability is out of scope for now.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to cover a few more controversial changes to mana infusion with the aim to get rid of many alchemy catalyst cycles and all conjuration catalyst recipes. These feel cheap and uninspired in terms of game design, and are partially outdated due to vanilla changes. Instead, the focus is moved towards a more natural availability of the resources these recipes intended to provide.
Overview of changes: