Work around broken mods that *throw exceptions* in getCraftingRemainingItem bringing down RecipeCrawlHandler as collateral damage

Author: quat1024

changelog.txt

@@ -0,0 +1 @@
+- Work around broken mods that *throw exceptions* in getCraftingRemainingItem bringing down RecipeCrawlHandler as collateral damage

src/main/java/org/violetmoon/zeta/util/handler/RecipeCrawlHandler.java

@@ -156,11 +156,18 @@ private static void digest(Recipe<?> recipe, RegistryAccess access) {
 		for (Ingredient ingredient : ingredients) {
 			for (ItemStack inStack : ingredient.getItems()) {
 				//don't include catalyst items. This includes partial ones like buckets and such
-				ItemStack remaining = inStack.getCraftingRemainingItem();
+				ItemStack remaining;
+
+				try {
+					remaining = inStack.getCraftingRemainingItem();
+				} catch(Exception e) {
+					ZetaMod.LOGGER.error("Item {} threw an exception from IForgeItemStack#getCraftingRemainingItem!! This is very broken, report to the author of that mod", inStack.getItem(), e);
+					continue;
+				}
 
 				if(remaining == null) {
 					//sigh. let's at least not make this into our problem
-					ZetaMod.LOGGER.error("Item {} returned NULL from getCraftingRemainingItem. This is wrong and will cause problems down the line", inStack.getItem());
+					ZetaMod.LOGGER.error("Item {} returned NULL from IForgeItemStack#getCraftingRemainingItem. This is wrong and will cause problems down the line", inStack.getItem());
 					continue;
 				}