AutoDNDWhilePlaying: add option to prevent status changes when invisible#3713
Open
KK2-5 wants to merge 6 commits intoVendicated:devfrom
Open
AutoDNDWhilePlaying: add option to prevent status changes when invisible#3713KK2-5 wants to merge 6 commits intoVendicated:devfrom
KK2-5 wants to merge 6 commits intoVendicated:devfrom
Conversation
Co-authored-by: thororen <78185467+thororen1234@users.noreply.github.com>
2 tasks
|
Hi — I opened #3755. CI is green; is anything blocking merge? |
Removed the 'excludeInvisible' setting to simplify status handling.
Owner
|
I don't think there is any scenario where someone who is invisible would like the plugin to change their status, so I removed the option |
Owner
|
tbh this plugin should also handle manual status changes
I think if the user manually changes their status we should just set savedStatus to null again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added as toggle to keep it simple and preserve the current behavior. Thought about letting you ignore specific statuses instead of just invisible, but that felt overkill for such a niche feature.