Skip to content

Commit a2ea4d3

Browse files
committed
Fix comparer attempting to handle non images
1 parent f4c55f8 commit a2ea4d3

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

src/Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project>
33
<PropertyGroup>
44
<NoWarn>CS1591;CS0649;NU1608;NU1109</NoWarn>
5-
<Version>3.7.4</Version>
5+
<Version>3.7.5</Version>
66
<AssemblyVersion>1.0.0</AssemblyVersion>
77
<ImplicitUsings>enable</ImplicitUsings>
88
<LangVersion>preview</LangVersion>

src/Directory.Packages.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
<PackageVersion Include="NUnit3TestAdapter" Version="5.1.0" />
1212
<PackageVersion Include="Polyfill" Version="8.9.0" />
1313
<PackageVersion Include="ProjectDefaults" Version="1.0.161" />
14-
<PackageVersion Include="Verify" Version="30.18.0" />
14+
<PackageVersion Include="Verify" Version="30.19.0" />
1515
<PackageVersion Include="Verify.DiffPlex" Version="3.1.2" />
16-
<PackageVersion Include="Verify.Nunit" Version="30.18.0" />
16+
<PackageVersion Include="Verify.Nunit" Version="30.19.0" />
1717
<PackageVersion Include="Microsoft.Sbom.Targets" Version="4.1.2" />
1818
</ItemGroup>
1919
</Project>

src/Verify.ImageMagick/VerifyImageMagick.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,18 @@ internal static Task<CompareResult> Compare(double threshold, ErrorMetric metric
9696
/// </summary>
9797
public static void ImageMagickComparer(this VerifySettings settings, double threshold = .005, ErrorMetric metric = ErrorMetric.Fuzz) =>
9898
settings.UseStreamComparer(
99-
(received, verified, _) => Compare(threshold, metric, received, verified));
99+
(received, verified, _) => Compare(threshold, metric, received, verified),
100+
extensions: ["png", "jpg", "bmp", "tiff"]);
100101

101102
/// <summary>
102103
/// Helper method that calls <see cref="RegisterPdfToPngConverter"/> and
103104
/// <see cref="RegisterComparers"/>(threshold = .005, metric = ErrorMetric.Fuzz)
104105
/// </summary>
105-
public static SettingsTask ImageMagickComparer(this SettingsTask settings, double threshold = .005, ErrorMetric metric = ErrorMetric.Fuzz) =>
106-
settings.UseStreamComparer(
107-
(received, verified, _) => Compare(threshold, metric, received, verified));
106+
public static SettingsTask ImageMagickComparer(this SettingsTask settings, double threshold = .005, ErrorMetric metric = ErrorMetric.Fuzz)
107+
{
108+
settings.CurrentSettings.ImageMagickComparer(threshold, metric);
109+
return settings;
110+
}
108111

109112
public static void RegisterComparer(double threshold, ErrorMetric metric, string extension) =>
110113
VerifierSettings.RegisterStreamComparer(
@@ -133,7 +136,6 @@ static Task<CompareResult> Compare(double threshold, ErrorMetric metric, IMagick
133136
"""));
134137
}
135138

136-
137139
//
138140
// static ImageInfo BuildInfo(MagickImage image) =>
139141
// new()
@@ -165,4 +167,4 @@ static Task<CompareResult> Compare(double threshold, ErrorMetric metric, IMagick
165167
// BlackPointCompensation = image.BlackPointCompensation,
166168
// AnimationTicksPerSecond = image.AnimationTicksPerSecond
167169
// };
168-
}
170+
}

0 commit comments

Comments
 (0)