Skip to content

feat: flutter 3.29 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
7 tasks
lishaduck opened this issue Feb 14, 2025 · 3 comments · May be fixed by #143
Open
7 tasks

feat: flutter 3.29 #136

lishaduck opened this issue Feb 14, 2025 · 3 comments · May be fixed by #143
Labels
feature A new feature or request

Comments

@lishaduck
Copy link
Contributor

lishaduck commented Feb 14, 2025 •
edited
Loading

Description

Update lints list for the latest Dart release.

Stable:

  • unnecessary_underscores (Dart team is currently debating if it belongs in the core or recommended set)
  • strict_top_level_inference (Continues down the vein of preventing dynamic from leaking in, currently proposed for lints)

Formatting changes:

  • Remove require_trailing_commas

Experimental:

  • unnecessary_async
  • unsafe_variance (this actually looks really useful, but maybe I just write too much generic code)

Style changes:

  • omit_obvious_property_types
  • specify_nonobvious_property_types

↑ These new lints align with Effective Dart better than the current style, but are experimental. I personally think they fit well with VGA's style, but it's very much a style choice on y'all's part.

Removed lints: already handled 🥳

Requirements

Have a decision made on the updates.

Additional Context

Just the quarterly issue filing.
@lishaduck lishaduck added the feature A new feature or request label Feb 14, 2025
@felangel
Copy link
Contributor

I would also consider removing require_trailing_commas since it's no longer needed if projects adopt the new Dart 3.7 formatting (trailing commas are automatically added/removed by the formatter): dart-lang/sdk#60119

@lishaduck
Copy link
Contributor Author

I would also consider removing require_trailing_commas since it's no longer needed if projects adopt the new Dart 3.7 formatting (trailing commas are automatically added/removed by the formatter): dart-lang/sdk#60119

As a matter of fact, it conflicts now, because the Tall Style formatter now supports block-style formatting in more spots (which is a cross between tall and short style for closures).

@wolfenrain
Copy link
Member

I'll start planning in the work for this today and hopefully we can get it tackled as soon as possible. I personally am happy we finally get these interesting changes to the analyzer, thank you @lishaduck for providing the worked out info! Makes my life easier

@masa-tokyo masa-tokyo mentioned this issue Feb 18, 2025
Merged
passsy added a commit to passsy/dart-lint that referenced this issue Feb 24, 2025
@passsy
Disable require_trailing_commas because it conflicts with the new Dar…
5b25ca9 
…t 3.7 formatter

Fixes #80
Related dart-lang/dart_style#1652
Related VeryGoodOpenSource/very_good_analysis#136
MrCsabaToth added a commit to Open-Multi-Modal-Personal-Assistant/OpenMMPA that referenced this issue Apr 19, 2025
@MrCsabaToth
Flutter Upgrade 3.29.2 -> 3.29.3, disable require_trailing_commas (see …
fc9de38 
…VeryGoodOpenSource/very_good_analysis#136, dart format . undoes it)

objectbox_flutter_libs 4.2.0
@wolfenrain wolfenrain linked a pull request Apr 25, 2025 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature or request
Projects
VGV Open Source 🦄 🧙🌟
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update VGA for Dart v3.7.0 VeryGoodOpenSource/very_good_analysis
3 participants
@felangel @wolfenrain @lishaduck