fix:remove the duplicate code #81
Conversation
|
@valyala I hope you can take a lokk at it sometime |
There was a problem hiding this comment.
Pull Request Overview
This PR removes duplicate initialization code and simplifies atomic operations in the bucket Reset method. The changes eliminate redundant map initialization and replace atomic store operations with direct assignments under lock protection.
- Removes duplicate
b.m = make(map[uint64]uint64)initialization in bucket Init method - Replaces atomic store operations with direct assignments in Reset method since they occur under mutex protection
| atomic.StoreUint64(&b.misses, 0) | ||
| atomic.StoreUint64(&b.collisions, 0) | ||
| atomic.StoreUint64(&b.corruptions, 0) | ||
| b.getCalls = 0 |
There was a problem hiding this comment.
Direct assignment to b.getCalls may cause race conditions if other goroutines read this field concurrently without holding the mutex. If getCalls is accessed outside the mutex elsewhere in the code, atomic operations should be retained.
| atomic.StoreUint64(&b.collisions, 0) | ||
| atomic.StoreUint64(&b.corruptions, 0) | ||
| b.getCalls = 0 | ||
| b.setCalls = 0 |
There was a problem hiding this comment.
Direct assignment to b.setCalls may cause race conditions if other goroutines read this field concurrently without holding the mutex. If setCalls is accessed outside the mutex elsewhere in the code, atomic operations should be retained.
| atomic.StoreUint64(&b.corruptions, 0) | ||
| b.getCalls = 0 | ||
| b.setCalls = 0 | ||
| b.misses = 0 |
There was a problem hiding this comment.
Direct assignment to b.misses may cause race conditions if other goroutines read this field concurrently without holding the mutex. If misses is accessed outside the mutex elsewhere in the code, atomic operations should be retained.
| b.getCalls = 0 | ||
| b.setCalls = 0 | ||
| b.misses = 0 | ||
| b.collisions = 0 |
There was a problem hiding this comment.
Direct assignment to b.collisions may cause race conditions if other goroutines read this field concurrently without holding the mutex. If collisions is accessed outside the mutex elsewhere in the code, atomic operations should be retained.
| b.collisions = 0 | |
| atomic.StoreUint64(&b.collisions, 0) |
| b.setCalls = 0 | ||
| b.misses = 0 | ||
| b.collisions = 0 | ||
| b.corruptions = 0 |
There was a problem hiding this comment.
Direct assignment to b.corruptions may cause race conditions if other goroutines read this field concurrently without holding the mutex. If corruptions is accessed outside the mutex elsewhere in the code, atomic operations should be retained.
| b.corruptions = 0 | |
| atomic.StoreUint64(&b.corruptions, 0) |
1 participant
1.Remove the duplicate code 'b.m = make(map[uint64]uint64)'
2.Because of the protection of the lock, you can operate without using atoms