Fix potential output blocks when triggering external process

Author: Viladoman

CompileScore/Shared/Editor/ExternalProcess.cs

@@ -8,35 +8,17 @@ public static class ExternalProcess
     {
         public static int ExecuteSync(string toolPath, string arguments)
         {
-            var process = StartProcess(toolPath, arguments);
-
-            if (process == null)
-            {
-                return -1;
-            }
-
-            WaitForExit(process);
-
-            return process.ExitCode;
+            return RunProcess(toolPath, arguments);
         }
 
-        public static async Task<int> ExecuteAsync(string toolPath, string arguments)
+        public static Task<int> ExecuteAsync(string toolPath, string arguments)
         {
-            var process = StartProcess(toolPath, arguments);
-
-            if (process == null)
-            {
-                return -1;
-            }
-
-            await Task.Run(() => WaitForExit(process));
-
-            return process.ExitCode;
+			return Task.Run(() => RunProcess(toolPath, arguments));
         }
 
-        private static Process StartProcess(string toolPath, string arguments)
+        private static int RunProcess(string toolPath, string arguments)
         {
-            var process = new Process();
+            Process process = new Process();
 
             process.StartInfo.FileName = toolPath;
             process.StartInfo.Arguments = arguments;
@@ -46,36 +28,38 @@ private static Process StartProcess(string toolPath, string arguments)
             process.StartInfo.CreateNoWindow = true;
             process.StartInfo.WindowStyle = ProcessWindowStyle.Hidden;
 
+			process.ErrorDataReceived += (sender, errorLine) =>
+            {
+                if (errorLine.Data != null)
+                {
+                    OutputLine(errorLine.Data);
+                }
+            };
+            process.OutputDataReceived += (sender, outputLine) =>
+            {
+                if (outputLine.Data != null)
+                {
+                    OutputLine(outputLine.Data);
+                }
+            };
+
             try
             {
                 process.Start();
+                process.BeginErrorReadLine();
+                process.BeginOutputReadLine();
+                process.WaitForExit();
             }
             catch (Exception error)
             {
                 OutputLine(error.Message);
-                return null;
+                return -1;
             }
 
-            return process;
-        }
-
-        private static void WaitForExit(Process process)
-        {
-            //Handle output
-            while (!process.StandardOutput.EndOfStream || !process.StandardError.EndOfStream)
-            {
-                if (!process.StandardOutput.EndOfStream)
-                {
-                    OutputLine(process.StandardOutput.ReadLine());
-                }
-
-                if (!process.StandardError.EndOfStream)
-                {
-                    OutputLine(process.StandardError.ReadLine());
-                }
-            }
+            int exitCode = process.ExitCode;
+            process.Close();
 
-            process.WaitForExit();
+            return exitCode;
         }
 
         private static void OutputLine(string str)

CompileScore/VSIX17/source.extension.vsixmanifest

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
     <Metadata>
-        <Identity Id="CompileScore.6e13b50f-06b4-40b3-8168-97c8ac3974d0" Version="1.8.3.1" Language="en-US" Publisher="Ramon Viladomat" />
+        <Identity Id="CompileScore.6e13b50f-06b4-40b3-8168-97c8ac3974d0" Version="1.8.4" Language="en-US" Publisher="Ramon Viladomat" />
         <DisplayName>Compile Score 2022</DisplayName>
         <Description xml:space="preserve">C/C++ compile times data viewer and text highlight for Clang and MSVC.</Description>
         <MoreInfo>https://github.com/Viladoman/CompileScore</MoreInfo>