refactor(chart-advisor): refactor whole chart advisor module

[bingling-sama]

[中文版模板 / Chinese template]

🤔 This is a ...

• New feature
• Bug fix
• TypeScript definition update
• Bundle size optimization
• Performance optimization
• Enhancement feature
• Refactoring
• Update dependency
• Code style optimization
• Test Case
• Branch merge
• Release
• Site / documentation update
• Demo update
• Workflow
• Other (about what?)

🔗 Related issue link

implementing #241

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

Problems:

Problem Type	Manifestation in Codebase	Impact
Complexity	Large, monolithic functions; deep nesting; implicit data flow	Hard to read, debug, or extend
Coupling	Tight integration of logic and utilities	Difficult to refactor or reuse
Testability	No colocated tests; hard to isolate units; no DI	Hard to write meaningful unit tests
Modularity	Chart-specific logic inline, not modular	Low reusability, high duplication risk

Refactor Plan:

• Decompose Monolithic Functions
  Break down large functions (e.g., scorer, baseBarScore) into smaller, single-responsibility functions.
  Extract chart-type-specific logic into separate modules/files.
• Modularize Rule and Scoring Logic
  Move rule definitions and configurations out of inline objects into dedicated, reusable modules.
  Create a registry or factory for chart scoring strategies.
• Improve Data Flow and Parameter Handling
  Replace large, loosely-typed parameter objects with well-defined interfaces.
  Pass only necessary data to each function to reduce implicit dependencies.
• Introduce Dependency Injection
  Inject utility functions and configuration instead of importing them directly.
  Allow for easy mocking/stubbing in tests.
• Increase Testability
  Expose internal logic and utility functions for direct testing.
  Write unit tests for each isolated function and rule.
  Add integration tests for high-level scoring flows.
• Enhance Documentation and Typing
  Add clear JSDoc/type annotations for all public and internal APIs.
  Document the expected input/output for each function.

📝 Changelog

Language	Changelog
🇺🇸 English	refactor scorer module
🇨🇳 Chinese	重构 scorer 模块

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• TypeScript definition is updated/provided or not needed
• Changelog is provided or not needed

---

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

[Copilot]

Pull Request Overview

This PR refactors the chart advisor module to improve modularity and testability by decomposing monolithic functions and organizing reusable utility and rule functions.

• Extracted utility functions for validation and calculation.
• Introduced dedicated scorers for pie, line, and bar charts that compose common and chart-specific rules.
• Modularized rule configurations and composed rule logic to streamline scoring workflows.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/chart-advisor/src/utils/validation.ts	Added basic validation functions for chart data.
packages/chart-advisor/src/utils/calculation.ts	Added statistical calculation functions.
packages/chart-advisor/src/types/index.ts	Defined types and interfaces for chart advisor.
packages/chart-advisor/src/scorers/*.ts	Created scorers for pie, line, and bar charts.
packages/chart-advisor/src/rules/config.ts	Introduced default scoring configurations.
packages/chart-advisor/src/rules/compose.ts	Implemented rule composition to aggregate scores.
packages/chart-advisor/src/rules/common.ts	Defined shared scoring rules including data range, dimension-metric checks, and others.
packages/chart-advisor/src/tests/scorers/*.test.ts	Added tests to validate scoring behavior.

Comments suppressed due to low confidence (2)

packages/chart-advisor/src/rules/common.ts:18

• [nitpick] The rule is named 'dimensionMetric' while its related configuration key is 'dimensionCheck'; consider renaming for consistency, for example, to 'dimensionCheckRule'.

export const dimensionMetricRule = (config: ScoringConfig): Rule => ({

packages/chart-advisor/src/utils/validation.ts:3

• [nitpick] Consider adding more detailed JSDoc comments to document the input parameters and return values of the validation functions for improved clarity.

// 校验 bars 是否为有效数组且长度大于0

[xile611]

类型定义补充一下具体的注释

[xile611]

为什么要限制有 bars 这个字段，我们的数据可能是任意的二维表

[xile611]

data.bars 是哪里来的？

[xile611]

这里为啥改了scorer 的输入类型？