Use the IP from the Server Post if available #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of loading the provider API, the IP address can be called directly from the post meta in most cases.
|
@batonac - Curious - what's the purpose for this change? Is it a performance optimization change or to fix a bug you encountered? |
|
It's a bug workaround, truthfully, since the Proxmox API provider suddenly stopped working with the existing IP address retrieval code. I haven't had time to diagnose the issue yet, but I felt like submitting this change since it seems it could be justified on the basis of a performance optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading the provider API, the IP address can be called directly from the post meta in most cases.