Skip to content

update crates to latest #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

update crates to latest #212

merged 1 commit into from
Apr 27, 2025

Conversation

ibigbug
Copy link
Member

@ibigbug ibigbug commented Apr 27, 2025

  • update windows-rs and other rates
  • rust edition 2024

#211

@ibigbug ibigbug requested a review from Copilot April 27, 2025 16:01
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates various crates (including windows-rs, clap, fern, uuid, and base64) to their latest versions and updates the project to use Rust edition 2024. Key changes include:

  • Changing data types for terminal I/O from Arc<[u8]> to Vec for improved ergonomics.
  • Updating Windows API calls and error handling in the terminal implementation.
  • Adjustments in clap usage in main.rs to align with the v4 API changes.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/terminal/mod.rs Updated channel payload types from Arc<[u8]> to Vec.
src/terminal/impl_win/terminal.rs Modified handle types and Windows API calls for improved error handling and updated dependency usage.
src/terminal/impl_win/process.rs Adjusted unsafe blocks and Windows API call patterns in process setup.
src/main.rs Updated clap API usage in command-line argument parsing.
src/commands/record.rs Updated channels payload types and thread loops to use Vec.
src/commands/api/asciinema.rs Updated base64 encoding usage to the new BASE64_STANDARD pattern.
Cargo.toml Bumped Rust edition and updated dependency versions.

@ibigbug ibigbug merged commit 564c494 into main Apr 27, 2025
2 checks passed
@ibigbug ibigbug deleted the update-crates branch April 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant