Skip to content

feat: add enableMFA in to the flow sequence #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add enableMFA in to the flow sequence #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo/redirect-flow-example/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 20 additions & 3 deletions demo/redirect-flow-example/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,23 @@ function App() {
setProvider(coreKitInstance.provider);
}
else {
coreKitInstance.setupProvider({ chainConfig: DEFAULT_CHAIN_CONFIG }).then((provider) => {
if (coreKitInstance.status === COREKIT_STATUS.LOGGED_IN) {
coreKitInstance.setupProvider({ chainConfig: DEFAULT_CHAIN_CONFIG }).then((provider) => {

setProvider(coreKitInstance.provider);
});
setProvider(coreKitInstance.provider);
});
}
}
setCoreKitStatus(coreKitInstance.status);


try {
let result = securityQuestion.getQuestion(coreKitInstance!);
setQuestion(result);
} catch (e) {
setQuestion(undefined);
uiConsole(e);
}
} catch (error: unknown) {
console.error(error);
}
Expand Down Expand Up @@ -225,14 +236,20 @@ function App() {
throw new Error("backupFactorKey not found");
}
const factorKey = new BN(backupFactorKey, "hex")
console.log(factorKey)
await coreKitInstance.inputFactorKey(factorKey);
console.log(coreKitInstance)

setCoreKitStatus(coreKitInstance.status);

if (coreKitInstance.status === COREKIT_STATUS.REQUIRED_SHARE) {
uiConsole("required more shares even after inputing backup factor key, please enter your backup/ device factor key, or reset account [unrecoverable once reset, please use it with caution]");
}

if (coreKitInstance.provider) {
setProvider(coreKitInstance.provider);
} else if (coreKitInstance.status === COREKIT_STATUS.LOGGED_IN) {
await coreKitInstance.setupProvider({ chainConfig: DEFAULT_CHAIN_CONFIG })
}
}

Expand Down
39 changes: 31 additions & 8 deletions demo/redirect-flow-example/src/flow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,36 @@

import { WEB3AUTH_NETWORK_TYPE, Web3AuthMPCCoreKit, TssSecurityQuestion } from "@web3auth/mpc-core-kit";
import { getPubKeyPoint } from "@tkey-mpc/common-types";
import { WEB3AUTH_NETWORK_TYPE, Web3AuthMPCCoreKit, TssSecurityQuestion, getHashedPrivateKey } from "@web3auth/mpc-core-kit";
import BN from "bn.js";

export const flow = async (params: { selectedNetwork: WEB3AUTH_NETWORK_TYPE, manualSync: boolean, setupProviderOnInit: boolean, verifier: string, verifierId: string, idToken: string }) => {
const startTime = Date.now();
console.log("startTime", startTime);

const initStart = Date.now();
console.log("initStart", initStart);
const web3AuthClientId = "BPi5PB_UiIZ-cPz1GtV5i1I2iOSOHuimiXBI0e-Oe_u6X3oVAbCiAZOTEBtTXw4tsluTITPqA8zMsfxIKMjiqNQ";
const coreKitInstance = new Web3AuthMPCCoreKit(
{
web3AuthClientId: 'BPi5PB_UiIZ-cPz1GtV5i1I2iOSOHuimiXBI0e-Oe_u6X3oVAbCiAZOTEBtTXw4tsluTITPqA8zMsfxIKMjiqNQ',
web3AuthClientId,
web3AuthNetwork: params.selectedNetwork,
uxMode: 'redirect',
manualSync: params.manualSync,
setupProviderOnInit: params.setupProviderOnInit,
}
);

// init can be called before login is triggered, should it is excluded from the login time
await coreKitInstance.init({ handleRedirectResult: false, rehydrate: false });
const startTime = Date.now();
console.log("done init", startTime);


console.log("init", startTime - initStart);

console.log("startTime", startTime);
await coreKitInstance.loginWithJWT({
verifier: params.verifier,
verifierId: params.verifierId,
idToken: params.idToken,
}, { prefetchTssPublicKeys: 2 });
}, { prefetchTssPublicKeys: 3});

let loggedInTime = Date.now();
console.log("logged Time :", loggedInTime);
Expand All @@ -39,13 +48,27 @@ export const flow = async (params: { selectedNetwork: WEB3AUTH_NETWORK_TYPE, man
console.log("SQ time", SqFactorTime);
console.log(SqFactorTime - loggedInTime);

let securityFactor = await securityQuestion.recoverFactor(coreKitInstance, "answer");


// update current Factor key with security factor
await coreKitInstance.inputFactorKey(new BN(securityFactor, "hex"));
// enable mfa ( by deleting Hash Factor )
const hashFactor = getHashedPrivateKey(coreKitInstance.state.oAuthKey!, web3AuthClientId)
const hashedFactorPub = getPubKeyPoint(hashFactor);
await coreKitInstance.deleteFactor(hashedFactorPub, hashFactor);

let deletedFactorTime = Date.now();
console.log("deleted hash factor (enableMFA)", deletedFactorTime);
console.log(deletedFactorTime - SqFactorTime);

await coreKitInstance.commitChanges();

let commitTime = Date.now();
console.log("commit :", commitTime);
console.log(commitTime - SqFactorTime);
console.log(commitTime - deletedFactorTime);

console.log("total time", commitTime - startTime);
console.log("total login time", commitTime - startTime);


}